Fixes regression in painting info bubble. This is the result of...

chrome/browser/views/info_bubble.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/info_bubble.h"
 
 #include "base/win_util.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/views/frame/browser_view.h"
 #include "chrome/common/gfx/chrome_canvas.h"
@@ skipping 342 matching lines @@
                       kInfoBubbleCornerWidth, bubble_y,
                       border_w, bubble_h);
   // Right Column.
   canvas->FillRectInt(kBackgroundColor,
                       bubble_w - kInfoBubbleCornerWidth,
                       bubble_y + kInfoBubbleCornerHeight,
                       kInfoBubbleCornerWidth, border_h);
 
   // Draw the border.
   // Top border.
-  canvas->DrawRectInt(kBorderColor1,
+  canvas->DrawLineInt(kBorderColor1,
                       kInfoBubbleCornerWidth, bubble_y,
-                      border_w,
-                      0);
+                      kInfoBubbleCornerWidth + border_w, bubble_y);
   // Bottom border.
-  canvas->DrawRectInt(kBorderColor1,
+  canvas->DrawLineInt(kBorderColor1,
                       kInfoBubbleCornerWidth, bubble_y + bubble_h - 1,
-                      border_w, 0);
+                      kInfoBubbleCornerWidth + border_w,
+                      bubble_y + bubble_h - 1);
   // Left border.
-  canvas->DrawRectInt(kBorderColor1,
+  canvas->DrawLineInt(kBorderColor1,
                       bubble_x, bubble_y + kInfoBubbleCornerHeight,
-                      0, border_h);
+                      bubble_x, bubble_y + kInfoBubbleCornerHeight + border_h);
 
   // Right border.
-  canvas->DrawRectInt(kBorderColor1,
+  canvas->DrawLineInt(kBorderColor1,
                       width() - 1, bubble_y + kInfoBubbleCornerHeight,
-                      0, border_h);

[Dean McNamee, 2009/04/15 08:33:51]

couldn't you have just changed all of these 0s to 1s?

[sky, 2009/04/15 14:44:22]

That resulted in at least a two pixel line. To me that implies Skia's rects are
outset, which means we can never get a single pixel line with the function the
way it is.

+                      width() - 1,
+                      bubble_y + kInfoBubbleCornerHeight + border_h);
 
   // Draw the corners.
   canvas->DrawBitmapInt(*kInfoBubbleCornerTopLeft, 0, bubble_y);
   canvas->DrawBitmapInt(*kInfoBubbleCornerTopRight,
                         bubble_w - kInfoBubbleCornerWidth, bubble_y);
   canvas->DrawBitmapInt(*kInfoBubbleCornerBottomLeft, 0,
                         bubble_y + bubble_h - kInfoBubbleCornerHeight);
   canvas->DrawBitmapInt(*kInfoBubbleCornerBottomRight,
                         bubble_w - kInfoBubbleCornerWidth,
                         bubble_y + bubble_h - kInfoBubbleCornerHeight);
@@ skipping 29 matching lines @@
     x -= kArrowXOffset;
   else
     x = x + kArrowXOffset - pref.width();
   if (IsTop()) {
     y = position_relative_to.bottom() + kArrowToContentPadding;
   } else {
     y = position_relative_to.y() - kArrowToContentPadding - pref.height();
   }
   return gfx::Rect(x, y, pref.width(), pref.height());
 }