Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 67149: Fixes regression in painting info bubble. This is the result of... (Closed)

Created:
11 years, 8 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes regression in painting info bubble. This is the result of changes to DrawRectInt. Previously a width/height of 0 was treated as a 1 pixel line, where as now nothing gets drawn. I've special cased this again. BUG=9931 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13742

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M chrome/browser/views/info_bubble.cc View 1 chunk +10 lines, -9 lines 2 comments Download
M chrome/common/gfx/chrome_canvas.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/gfx/chrome_canvas.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
11 years, 8 months ago (2009-04-14 23:40:12 UTC) #1
brettw
LGTM, <sigh>
11 years, 8 months ago (2009-04-14 23:49:01 UTC) #2
Peter Kasting
Do we _have_ to do this? Can we change callers to explicitly do something better, ...
11 years, 8 months ago (2009-04-14 23:50:21 UTC) #3
sky
Ok, I added DrawLineInt.
11 years, 8 months ago (2009-04-15 00:10:37 UTC) #4
Peter Kasting
On 2009/04/15 00:10:37, sky wrote: > Ok, I added DrawLineInt. I love Scott and he ...
11 years, 8 months ago (2009-04-15 00:14:04 UTC) #5
brettw
On 2009/04/15 00:14:04, pkasting wrote: > I love Scott and he is awesome and sweet ...
11 years, 8 months ago (2009-04-15 02:37:29 UTC) #6
brettw
On 2009/04/15 00:14:04, pkasting wrote: > I love Scott and he is awesome and sweet ...
11 years, 8 months ago (2009-04-15 02:37:37 UTC) #7
Dean McNamee
Sorry, I kinda thought this might happen, I should have looked at it. Thanks, LG. ...
11 years, 8 months ago (2009-04-15 08:33:50 UTC) #8
sky
11 years, 8 months ago (2009-04-15 14:44:22 UTC) #9
http://codereview.chromium.org/67149/diff/1004/1006
File chrome/browser/views/info_bubble.cc (left):

http://codereview.chromium.org/67149/diff/1004/1006#oldcode379
Line 379: 0, border_h);
On 2009/04/15 08:33:51, Dean McNamee wrote:
> couldn't you have just changed all of these 0s to 1s?

That resulted in at least a two pixel line. To me that implies Skia's rects are
outset, which means we can never get a single pixel line with the function the
way it is.

Powered by Google App Engine
This is Rietveld 408576698