Fixes regression in painting info bubble. This is the result of...

Fixes regression in painting info bubble. This is the result of
changes to DrawRectInt. Previously a width/height of 0 was treated as a 1
pixel line, where as now nothing gets drawn. I've special cased this
again.

BUG=9931
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13742

[brettw, 2009-04-14 23:49:01]

LGTM, <sigh>

[Peter Kasting, 2009-04-14 23:50:21]

Do we _have_ to do this?  Can we change callers to explicitly do something
better, like set a size of 1?  This just seems really wrong.

[sky, 2009-04-15 00:10:37]

Ok, I added DrawLineInt.

[Peter Kasting, 2009-04-15 00:14:04]

On 2009/04/15 00:10:37, sky wrote:
> Ok, I added DrawLineInt.

I love Scott and he is awesome and sweet

[brettw, 2009-04-15 02:37:29]

On 2009/04/15 00:14:04, pkasting wrote:
> I love Scott and he is awesome and sweet

I agree with Peter. LGTM

Can you add a comment to the DrawRectInt function about whatever issue this is
so callers know to use the line function instead?

[brettw, 2009-04-15 02:37:37]

On 2009/04/15 00:14:04, pkasting wrote:
> I love Scott and he is awesome and sweet

I agree with Peter. LGTM

Can you add a comment to the DrawRectInt function about whatever issue this is
so callers know to use the line function instead?

[Dean McNamee, 2009-04-15 08:33:50]

Sorry, I kinda thought this might happen, I should have looked at it.

Thanks, LG.

http://codereview.chromium.org/67149/diff/1004/1006
File chrome/browser/views/info_bubble.cc (left):

http://codereview.chromium.org/67149/diff/1004/1006#oldcode379
Line 379: 0, border_h);
couldn't you have just changed all of these 0s to 1s?

[sky, 2009-04-15 14:44:22]

http://codereview.chromium.org/67149/diff/1004/1006
File chrome/browser/views/info_bubble.cc (left):

http://codereview.chromium.org/67149/diff/1004/1006#oldcode379
Line 379: 0, border_h);
On 2009/04/15 08:33:51, Dean McNamee wrote:
> couldn't you have just changed all of these 0s to 1s?

That resulted in at least a two pixel line. To me that implies Skia's rects are
outset, which means we can never get a single pixel line with the function the
way it is.