linux: make windowless plugins work again after r12179 regressed it.

linux: make windowless plugins work again after r12179 regressed it.

r12179 makes painting always call DidMove(), even when the plugin hasn't moved,
in case the cutout rects need to change.  DidMove() on Linux test_shell causes
the window to invalidate, causing an endless cycle of repaints.

  r12179: http://src.chromium.org/viewvc/chrome?view=rev&revision=12179

This code will be very different in the real multiproc case, so this is just
the minimal change to make test_shell work again.

BUG=10059

[Evan Martin, 2009-04-14 23:28:47]

ananta/dean review

man, this took me *so* long to figure out.  :~(

[jam, 2009-04-15 00:42:02]

lgtm

can a regression test be added?

[ananta, 2009-04-15 01:28:28]

LGTM.

[Dean McNamee, 2009-04-15 08:30:27]

:(

LG

http://codereview.chromium.org/67147/diff/1/3
File webkit/tools/test_shell/test_webview_delegate_gtk.cc (right):

http://codereview.chromium.org/67147/diff/1/3#newcode250
Line 250: g_value_unset(&value);
I would have pulled this out, but it's ok.

[Evan Martin, 2009-04-15 16:03:38]

http://codereview.chromium.org/67147/diff/1/3
File webkit/tools/test_shell/test_webview_delegate_gtk.cc (right):

http://codereview.chromium.org/67147/diff/1/3#newcode250
Line 250: g_value_unset(&value);
On 2009/04/15 08:30:27, Dean McNamee wrote:
> I would have pulled this out, but it's ok.

I was concerned about some data structure inside the GValue needing to be freed.
 Though it's likely just a tagged union.

[Dean McNamee, 2009-04-15 16:05:54]

LG

http://codereview.chromium.org/67147/diff/1/3
File webkit/tools/test_shell/test_webview_delegate_gtk.cc (right):

http://codereview.chromium.org/67147/diff/1/3#newcode250
Line 250: g_value_unset(&value);
I meant I would have made a helper.

fixed_pos(GtkFixed, int& x, int& y);

Whatev, LG.

On 2009/04/15 16:03:38, Evan Martin wrote:
> On 2009/04/15 08:30:27, Dean McNamee wrote:
> > I would have pulled this out, but it's ok.
> 
> I was concerned about some data structure inside the GValue needing to be
freed.
>  Though it's likely just a tagged union.