Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: webkit/glue/webplugin_impl.cc

Issue 67147: linux: make windowless plugins work again after r12179 regressed it. (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/webplugin_impl.cc
diff --git a/webkit/glue/webplugin_impl.cc b/webkit/glue/webplugin_impl.cc
index 308e4eaacef6332f2696d5c953f1a549d04bb683..195fb167e09588acc7dd4fd11b1cef670d2fd52a 100644
--- a/webkit/glue/webplugin_impl.cc
+++ b/webkit/glue/webplugin_impl.cc
@@ -661,14 +661,16 @@ void WebPluginImpl::setFrameRect(const WebCore::IntRect& rect,
CalculateBounds(rect, &window_rect, &clip_rect, &cutout_rects);
if (widget_dimensions_changed) {
+ // Notify the plugin that its parameters have changed.
delegate_->UpdateGeometry(
webkit_glue::FromIntRect(window_rect),
webkit_glue::FromIntRect(clip_rect));
}
if (window_) {
- // Let the WebViewDelegate know that the plugin window needs to be moved,
- // so that all the HWNDs are moved together.
+ // Notify the window hosting the plugin (the WebViewDelegate) that
+ // it needs to adjust the plugin, so that all the HWNDs can be moved
+ // at the same time.
WebPluginGeometry move;
move.window = window_;
move.window_rect = webkit_glue::FromIntRect(window_rect);

Powered by Google App Engine
This is Rietveld 408576698