Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 6714040: Merge TemporaryScope with LexicalScope. (Closed)

Created:
9 years, 9 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge TemporaryScope with LexicalScope. BUG= TEST=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -125 lines) Patch
M src/parser.h View 3 chunks +4 lines, -2 lines 1 comment Download
M src/parser.cc View 17 chunks +101 lines, -123 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Martin Maly
Hi Kevin, finally got to merging the LexicalScope with TemporaryScope in the parser. Thank you! ...
9 years, 9 months ago (2011-03-21 03:48:13 UTC) #1
Lasse Reichstein
LGTM
9 years, 9 months ago (2011-03-21 06:21:36 UTC) #2
Kevin Millikin (Chromium)
9 years, 9 months ago (2011-03-21 08:27:06 UTC) #3
LGTM, much nicer.

Powered by Google App Engine
This is Rietveld 408576698