Chromium Code Reviews
Help | Chromium Project | Sign in
(735)

Issue 6714030: Cleanup preserved lib locking in portage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by davidjames
Modified:
2 years, 8 months ago
Reviewers:
zmedico
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Cleanup preserved lib locking in portage.

This change makes preserved lib modification atomic, and
prepares us for narrowing the scope of the merge lock.

R=zmedico@gmail.com
BUG=
TEST=

Patch Set 1 : Remove extra newlines #

Patch Set 2 : More conservative locking. #

Patch Set 3 : Cleanup, rebase against other patch #

Patch Set 4 : Rebase #

Patch Set 5 : Remove lock changes #

Patch Set 6 : Kill extra tab, rebase again #

Patch Set 7 : Fix typos #

Patch Set 8 : Simplify #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -120 lines) Lint Patch
M pym/_emerge/actions.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -7 lines 0 comments ? errors Download
M pym/_emerge/main.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments ? errors Download
M pym/portage/dbapi/vartree.py View 1 2 3 4 5 6 7 9 chunks +70 lines, -96 lines 0 comments ? errors Download
M pym/portage/util/_dyn_libs/PreservedLibsRegistry.py View 1 2 3 4 5 6 7 5 chunks +20 lines, -14 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 1
zmedico
2 years, 12 months ago #1
All _linkmap_rebuild calls belong within the scope of the plib_registry lock.
This requirement is not satisfied in the case where _prune_plib_registry relies
on a prior call to _linkmap_rebuild.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6