Issue 67135: Fix: Find box forwarding scroll messages to the page when it shouldn't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67135: Fix: Find box forwarding scroll messages to the page when it shouldn't (Closed)

Created:
11 years, 8 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A fix for the Find box forwarding scroll messages to the page when it shouldn't. TEST=Open Find on a page with scrollbars, type in 'nomatch', scroll to the middle of the page, set the cursor at the end of the Find text field and add '!', '(' and ')' to the search string. Make sure the page doesn't scroll. BUG=10509 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13696

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -23 lines)			Patch
M	chrome/browser/views/find_bar_view.cc	View		2 chunks	+6 lines, -14 lines	0 comments	Download
M	chrome/browser/views/find_bar_win.h	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/views/find_bar_win.cc	View	1 2	2 chunks	+24 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages