Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/browser/views/find_bar_view.cc

Issue 67135: Fix: Find box forwarding scroll messages to the page when it shouldn't (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/find_bar_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/find_bar_view.cc
===================================================================
--- chrome/browser/views/find_bar_view.cc (revision 13620)
+++ chrome/browser/views/find_bar_view.cc (working copy)
@@ -479,6 +479,12 @@
if (!container_->IsVisible())
return false;
+ // TODO(port): Handle this for other platforms.
+ #if defined(OS_WIN)
+ if (container_->MaybeForwardKeystrokeToWebpage(message, key, flags))
+ return true; // Handled, we are done!
+ #endif
+
switch (key) {
case VK_RETURN: {
// Pressing Return/Enter starts the search (unless text box is empty).
@@ -491,20 +497,6 @@
}
break;
}
-#if defined(OS_WIN)
- // TODO(port): Handle this for other platforms.
- case VK_HOME:
- case VK_END:
- // Ctrl+Home and Ctrl+End should be forwarded to the page.
- if (GetKeyState(VK_CONTROL) >= 0)
- return false; // Ctrl not pressed: Abort. Otherwise fall through.
- case VK_UP:
- case VK_DOWN:
- case VK_PRIOR: // Page up
- case VK_NEXT: // Page down
- container_->ForwardKeystrokeToWebpage(key);
- return true; // Message has been handled. No further processing needed.
-#endif
}
return false;
« no previous file with comments | « no previous file | chrome/browser/views/find_bar_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698