Issue 671243002: Fix the drp crash for real.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671243002: Fix the drp crash for real. (Closed)

Created:
6 years, 2 months ago by hush (inactive)

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews, android-webview-reviews_chromium.org, sgurun-gerrit only, benm (inactive)

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix the drp crash for real. There are 2 different path that can possibly lead to SetDataReductionProxyEnalbed: 1. AwContents initialization -> InitDataReductionProxyIfNecessary path 2. AwContents statistics SetDataReductionProxyEnalbed JNI path In both paths, we need to make sure before SetDataReductionProxyEnabed is called, we have set the statistics object on DataReductionProxySettings. BUG=b/17998706 Review URL: https://codereview.chromium.org/671823002 Cr-Commit-Position: refs/heads/master@{#300730} (cherry picked from commit 410c610dd19a78841551fcf4b2b9180dc6fa2b85) Committed: https://chromium.googlesource.com/chromium/src/+/3cef526be4c3760fcdf4a1ac599cc9070e025003

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	android_webview/browser/aw_browser_context.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

hush (inactive)

6 years, 2 months ago (2014-10-23 19:39:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3cef526be4c3760fcdf4a1ac599cc9070e025003.

Expand Messages | Collapse Messages