Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 671823002: Fix the drp crash for real. (Closed)

Created:
6 years, 2 months ago by hush (inactive)
Modified:
6 years, 2 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the drp crash for real. There are 2 different path that can possibly lead to SetDataReductionProxyEnalbed: 1. AwContents initialization -> InitDataReductionProxyIfNecessary path 2. AwContents statistics SetDataReductionProxyEnalbed JNI path In both paths, we need to make sure before SetDataReductionProxyEnabed is called, we have set the statistics object on DataReductionProxySettings. BUG=426140 Committed: https://crrev.com/410c610dd19a78841551fcf4b2b9180dc6fa2b85 Cr-Commit-Position: refs/heads/master@{#300730}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/browser/aw_browser_context.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hush (inactive)
This CL depends on https://codereview.chromium.org/651443005/ I will rebase later..
6 years, 2 months ago (2014-10-22 02:19:35 UTC) #6
sgurun-gerrit only
lgtm
6 years, 2 months ago (2014-10-22 17:55:02 UTC) #7
hush (inactive)
PTAL ps2
6 years, 2 months ago (2014-10-22 18:00:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671823002/100001
6 years, 2 months ago (2014-10-22 18:01:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:100001)
6 years, 2 months ago (2014-10-22 19:27:19 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:28:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/410c610dd19a78841551fcf4b2b9180dc6fa2b85
Cr-Commit-Position: refs/heads/master@{#300730}

Powered by Google App Engine
This is Rietveld 408576698