Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 671233004: Moves warning about invalid targets into 'invalid_targets' in result (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Moves warning about invalid targets into 'invalid_targets' in result Previously if an invalid_target was supplied analyze would report it via 'warning'. I'm moving that warning to 'invalid_targets' and providing the list of invalid targets there. BUG=426892 TEST=covered by tests R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1994

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M pylib/gyp/generator/analyzer.py View 1 2 5 chunks +10 lines, -6 lines 0 comments Download
M test/analyzer/gyptest-analyzer.py View 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
6 years, 1 month ago (2014-10-24 16:18:43 UTC) #2
scottmg
lgtm https://codereview.chromium.org/671233004/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/671233004/diff/20001/pylib/gyp/generator/analyzer.py#newcode14 pylib/gyp/generator/analyzer.py:14: warning: only supplied if there is a warning. ...
6 years, 1 month ago (2014-10-24 16:27:58 UTC) #3
sky
https://codereview.chromium.org/671233004/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/671233004/diff/20001/pylib/gyp/generator/analyzer.py#newcode14 pylib/gyp/generator/analyzer.py:14: warning: only supplied if there is a warning. On ...
6 years, 1 month ago (2014-10-24 16:30:12 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-10-24 16:31:37 UTC) #7
sky
6 years, 1 month ago (2014-10-24 18:16:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r1994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698