Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671173005: Deterministic build - Comparison step - sort the result list. (Closed)

Created:
6 years, 2 months ago by Sébastien Marchand
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Deterministic build - Comparison step - sort the result list. BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292635

Patch Set 1 #

Total comments: 2

Patch Set 2 : Smarter approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Sébastien Marchand
PTAL.
6 years, 2 months ago (2014-10-23 20:25:41 UTC) #2
M-A Ruel
https://codereview.chromium.org/671173005/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (right): https://codereview.chromium.org/671173005/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#newcode59 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:59: for f in first_list & second_list: for f in ...
6 years, 2 months ago (2014-10-23 20:32:06 UTC) #3
Sébastien Marchand
PTAnL. https://codereview.chromium.org/671173005/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (right): https://codereview.chromium.org/671173005/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#newcode59 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:59: for f in first_list & second_list: On 2014/10/23 ...
6 years, 2 months ago (2014-10-23 20:38:17 UTC) #4
M-A Ruel
lgtm
6 years, 2 months ago (2014-10-23 20:38:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671173005/20001
6 years, 2 months ago (2014-10-23 20:39:26 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 20:40:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 292635

Powered by Google App Engine
This is Rietveld 408576698