scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py - Issue 671173005: Deterministic build - Comparison step - sort the result list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

Issue 671173005: Deterministic build - Comparison step - sort the result list. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Smarter approach Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

diff --git a/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py b/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

index 1c3095e1094a94da2cfdb9cec167ee41f83c22ea..9e5535c7cb85cd205ef95d5d23e5f18fc29a84f3 100644

--- a/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

+++ b/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py

@@ -55,7 +55,7 @@ def compare_build_artifacts(first_dir, second_dir):

print >> sys.stderr, '\n'.join(' ' + i for i in sorted(diff))

res = 1

- for f in first_list & second_list:

+ for f in sorted(first_list & second_list):

first_file = os.path.join(first_dir, f)

second_file = os.path.join(second_dir, f)

if filecmp.cmp(first_file, second_file, shallow=False):

« no previous file with comments | « no previous file | no next file » | no next file with comments »