Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 671003002: Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2. (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding PreRole in blink side to expose HTML pre tag with correct MSAA+IA2. This is blink side CL to expose HTML pre tag in chromium side with proper MSAA+IA2 role. BUG=426053 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/core/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-10-22 19:09:05 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-23 16:13:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671003002/1
6 years, 2 months ago (2014-10-23 16:13:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33321)
6 years, 2 months ago (2014-10-23 18:16:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671003002/1
6 years, 2 months ago (2014-10-23 18:29:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184300
6 years, 2 months ago (2014-10-23 20:14:02 UTC) #10
leviw_travelin_and_unemployed
6 years, 2 months ago (2014-10-23 23:30:10 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/675033002/ by leviw@chromium.org.

The reason for reverting is: Broke the browser tests crbug.com/426608.

Powered by Google App Engine
This is Rietveld 408576698