components/content_settings/core/browser/BUILD.gn - Issue 670953006: Componentize HostContentSettingsMap and content settings providers.

Unified Diff: components/content_settings/core/browser/BUILD.gn

Issue 670953006: Componentize HostContentSettingsMap and content settings providers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings.gypi ('K') | « components/content_settings.gypi ('k') | components/content_settings/core/browser/DEPS » ('j') | components/content_settings/core/browser/host_content_settings_map.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/BUILD.gn

diff --git a/components/content_settings/core/browser/BUILD.gn b/components/content_settings/core/browser/BUILD.gn

index 4535a9af1ac849a78538c368ca4427f6f661243d..29c74033530e6c3f21a55bf9da74a0ad8febbf48 100644

--- a/components/content_settings/core/browser/BUILD.gn

+++ b/components/content_settings/core/browser/BUILD.gn

@@ -16,6 +16,18 @@ static_library("browser") {

"content_settings_rule.cc",

"content_settings_rule.h",

"local_shared_objects_counter.h",

+ 'content_settings/core/browser/content_settings_default_provider.cc',

vabr (Chromium) 2014/10/24 07:06:31 nit: alphabetise

vabr (Chromium) 2014/10/24 07:06:31 nit: drop the paths, leave just the file names

vabr (Chromium) 2014/10/24 07:06:31 nit: use double quotes (") instead of apostrophe (

vabr (Chromium) 2014/10/24 07:06:31 nit: indenting

Jun Mukai 2014/10/24 21:17:01 Done.

+ 'content_settings/core/browser/content_settings_default_provider.h',

+ 'content_settings/core/browser/content_settings_override_provider.cc',

+ 'content_settings/core/browser/content_settings_override_provider.h',

+ 'content_settings/core/browser/content_settings_policy_provider.cc',

+ 'content_settings/core/browser/content_settings_policy_provider.h',

+ 'content_settings/core/browser/content_settings_pref_provider.cc',

+ 'content_settings/core/browser/content_settings_pref_provider.h',

+ 'content_settings/core/browser/content_settings_utils.cc',

+ 'content_settings/core/browser/content_settings_utils.h',

+ 'content_settings/core/browser/host_content_settings_map.cc',

+ 'content_settings/core/browser/host_content_settings_map.h',

]

deps = [

@@ -28,6 +40,10 @@ source_set("unit_tests") {

testonly = true

sources = [

"content_settings_rule_unittest.cc",

+ 'content_settings/core/browser/content_settings_mock_provider.cc',

vabr (Chromium) 2014/10/24 07:06:31 ditto all four nits from above

Jun Mukai 2014/10/24 21:17:01 Done.

+ 'content_settings/core/browser/content_settings_mock_provider.h',

+ 'content_settings/core/browser/content_settings_provider_unittest.cc',

+ 'content_settings/core/browser/content_settings_utils_unittest.cc',

]

deps = [