Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 67094: Fix automated_ui_testing for XMLWriter (Closed)

Created:
11 years, 8 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix automated_ui_testing for XMLWriter There was an error in InitXMLReader where it tries to delete the bufffer_ member, setting it to null will make it work as mulhern stated. \src\chrome\Debug>automated_ui_tests.exe Started crash_service.exe so you know if a test crashes! [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from AutomatedUITest [ RUN ] AutomatedUITest.TheOneAndOnlyTest .\automated_ui_tests.cc(167): error: Value of: InitXMLReader() Actual: false Expected: true Error initializing XMLReader Then it crashes. TEST=Ran the test again, doesn't crash. BUG=9625 http://crbug.com/9625 Patch by Mohamed Mansour <m0.interactive@gmail.com>; in http://codereview.chromium.org/63001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/libxml_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698