Issue 63001: Fix XMLWriter crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63001: Fix XMLWriter crash (Closed)

Created:
11 years, 8 months ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, brettw, tony

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix automated_ui_testing for XMLWriter There was an error in InitXMLReader where it tries to delete the bufffer_ member, setting it to null will make it work as mulhern stated. \src\chrome\Debug>automated_ui_tests.exe Started crash_service.exe so you know if a test crashes! [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from AutomatedUITest [ RUN ] AutomatedUITest.TheOneAndOnlyTest .\automated_ui_tests.cc(167): error: Value of: InitXMLReader() Actual: false Expected: true Error initializing XMLReader Then it crashes. TEST=Ran the test again, doesn't crash. BUG=9625 http://crbug.com/9625

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/common/libxml_utils.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour (USE mhm)

Hi dean, by running these tests, it crashes since |buffer_| wasn't initialized. It doesn't crash ...

11 years, 8 months ago (2009-04-05 16:54:52 UTC) #1

Mohamed Mansour (USE mhm)

Added brett since he touched that file as well.

11 years, 8 months ago (2009-04-06 16:52:38 UTC) #2

Mohamed Mansour (USE mhm)

On 2009/04/06 17:01:20, brettw wrote: > LGTM Anyone could commit this?

11 years, 8 months ago (2009-04-13 18:33:47 UTC) #4

tony

11 years, 8 months ago (2009-04-13 22:17:43 UTC) #6

Committed in r13616 at http://codereview.chromium.org/67094

Expand Messages | Collapse Messages