Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 6709024: Merge 80797 (Closed)

Created:
9 years, 9 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
cevans, eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
A + LayoutTests/fast/dom/HTMLFormElement/invalid-form-field.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLFormElement/invalid-form-field-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLFormElement/move-option-between-documents.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLFormElement/move-option-between-documents-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/collection-nameditem-move-between-documents.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/collection-nameditem-move-between-documents-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/Document.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/WebCore/dom/Node.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/WebCore/html/FormAssociatedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/HTMLCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/xml/XPathResult.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
9 years, 9 months ago (2011-03-18 07:34:53 UTC) #1
eae
LGTM You might need to merge the change to WebCore/html/CollectionCache.h from r80797 as well.
9 years, 9 months ago (2011-03-18 18:07:57 UTC) #2
cevans
You mean http://trac.webkit.org/changeset/80802 ? On Fri, Mar 18, 2011 at 11:07 AM, <eae@chromium.org> wrote: > ...
9 years, 9 months ago (2011-03-18 18:17:04 UTC) #3
eae
9 years, 9 months ago (2011-03-18 18:19:41 UTC) #4
On Fri, Mar 18, 2011 at 11:16, Chris Evans <cevans@google.com> wrote:
> You mean http://trac.webkit.org/changeset/80802 ?

Yeah, that's the one.

Powered by Google App Engine
This is Rietveld 408576698