Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: minidump/test/minidump_file_writer_test_util.h

Issue 670853002: minidump: Migrate the rest of the tests to MinidumpWritableAtLocationDescriptor<>() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_thread_writer_test.cc ('k') | minidump/test/minidump_file_writer_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/test/minidump_file_writer_test_util.h
diff --git a/minidump/test/minidump_file_writer_test_util.h b/minidump/test/minidump_file_writer_test_util.h
index 846fa12bf01df701e8836ed06cf4840f86f6cd0f..9b561e05c9fe63018551c48f959ecc78a6ed69e8 100644
--- a/minidump/test/minidump_file_writer_test_util.h
+++ b/minidump/test/minidump_file_writer_test_util.h
@@ -45,13 +45,15 @@ const MINIDUMP_HEADER* MinidumpHeaderAtStart(
//! \brief Verifies, via gtest assertions, that a MINIDUMP_HEADER contains
//! expected values.
//!
-//! All fields in the MINIDUMP_HEADER will be evaluated. Most are compared to
-//! their correct default values. MINIDUMP_HEADER::NumberOfStreams is compared
-//! to \a streams, and MINIDUMP_HEADER::TimeDateStamp is compared to \a
-//! timestamp. Most fields are checked with nonfatal EXPECT-style assertions,
-//! but MINIDUMP_HEADER::NumberOfStreams and MINIDUMP_HEADER::StreamDirectoryRva
-//! are checked with fatal ASSERT-style assertions, because they must be
-//! correct in order for processing of the minidump to continue.
+//! All fields in the MINIDUMP_HEADER will be evaluated except for the Signature
+//! and Version fields, because those are checked by MinidumpHeaderAtStart().
+//! Most other fields are are compared to their correct default values.
+//! MINIDUMP_HEADER::NumberOfStreams is compared to \a streams, and
+//! MINIDUMP_HEADER::TimeDateStamp is compared to \a timestamp. Most fields are
+//! checked with nonfatal EXPECT-style assertions, but
+//! MINIDUMP_HEADER::NumberOfStreams and MINIDUMP_HEADER::StreamDirectoryRva are
+//! checked with fatal ASSERT-style assertions, because they must be correct in
+//! order for processing of the minidump to continue.
void VerifyMinidumpHeader(const MINIDUMP_HEADER* header,
uint32_t streams,
uint32_t timestamp);
« no previous file with comments | « minidump/minidump_thread_writer_test.cc ('k') | minidump/test/minidump_file_writer_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698