content/renderer/media/webrtc/media_stream_track_metrics.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_track_metrics.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/media_stream_remote_video_source.cc ('k') | content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_track_metrics.cc

diff --git a/content/renderer/media/webrtc/media_stream_track_metrics.cc b/content/renderer/media/webrtc/media_stream_track_metrics.cc

index f13d192241cb5150139afc5b4501192c8159ab2e..d4ce6b450fd9024a70d1be3670f1c058aeb827a8 100644

--- a/content/renderer/media/webrtc/media_stream_track_metrics.cc

+++ b/content/renderer/media/webrtc/media_stream_track_metrics.cc

@@ -27,7 +27,7 @@ class MediaStreamTrackMetricsObserver : public webrtc::ObserverInterface {

MediaStreamTrackMetrics::StreamType stream_type,

MediaStreamInterface* stream,

MediaStreamTrackMetrics* owner);

- virtual ~MediaStreamTrackMetricsObserver();

+ ~MediaStreamTrackMetricsObserver() override;

// Sends begin/end messages for all tracks currently tracked.

void SendLifetimeMessages(MediaStreamTrackMetrics::LifetimeEvent event);

@@ -39,7 +39,7 @@ class MediaStreamTrackMetricsObserver : public webrtc::ObserverInterface {

typedef std::set<std::string> IdSet;

// webrtc::ObserverInterface implementation.

- virtual void OnChanged() override;

+ void OnChanged() override;

template <class T>

IdSet GetTrackIds(const std::vector<rtc::scoped_refptr<T> >& tracks) {