content/renderer/media/webrtc/media_stream_remote_video_source.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/media_stream_remote_video_source.h ('k') | content/renderer/media/webrtc/media_stream_track_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_remote_video_source.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source.cc b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

index 0cff1978f9a13ed87a4acc3d24570be4506576b4..02bd5092dd3b449ac29204290d170172a17c83bb 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

@@ -29,13 +29,13 @@ class MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate

protected:

friend class base::RefCountedThreadSafe<RemoteVideoSourceDelegate>;

- virtual ~RemoteVideoSourceDelegate();

+ ~RemoteVideoSourceDelegate() override;

// Implements webrtc::VideoRendererInterface used for receiving video frames

// from the PeerConnection video track. May be called on a libjingle internal

// thread.

- virtual void SetSize(int width, int height) override;

- virtual void RenderFrame(const cricket::VideoFrame* frame) override;

+ void SetSize(int width, int height) override;

+ void RenderFrame(const cricket::VideoFrame* frame) override;

void DoRenderFrameOnIOThread(scoped_refptr<media::VideoFrame> video_frame,

const media::VideoCaptureFormat& format);