Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: src/lookup.cc

Issue 670623003: Handle property name "-0" correctly for typed arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: And another test for sloppy mode Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | test/mjsunit/harmony/typedarrays.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index bca0ab5d5f4379888605026c65528a1f7d5eb40c..34fa100775ffed3c0b235bebc74c8124a99755fc 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -316,6 +316,10 @@ bool LookupIterator::IsSpecialNumericIndex() const {
double d =
StringToDouble(isolate()->unicode_cache(), *name_string, NO_FLAGS);
if (!std::isnan(d)) {
+ if (String::Equals(isolate()->factory()->minus_zero_string(),
+ name_string))
+ return true;
+
Factory* factory = isolate()->factory();
Handle<Object> num = factory->NewNumber(d);
Handle<String> roundtrip_string = factory->NumberToString(num);
« no previous file with comments | « src/heap/heap.h ('k') | test/mjsunit/harmony/typedarrays.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698