Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: src/lookup.cc

Issue 670623003: Handle property name "-0" correctly for typed arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: And another test for sloppy mode Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap/heap.h ('k') | test/mjsunit/harmony/typedarrays.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/lookup-inl.h" 10 #include "src/lookup-inl.h"
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 } 309 }
310 310
311 311
312 bool LookupIterator::IsSpecialNumericIndex() const { 312 bool LookupIterator::IsSpecialNumericIndex() const {
313 if (GetStoreTarget()->IsJSTypedArray() && name()->IsString()) { 313 if (GetStoreTarget()->IsJSTypedArray() && name()->IsString()) {
314 Handle<String> name_string = Handle<String>::cast(name()); 314 Handle<String> name_string = Handle<String>::cast(name());
315 if (name_string->length() > 0) { 315 if (name_string->length() > 0) {
316 double d = 316 double d =
317 StringToDouble(isolate()->unicode_cache(), *name_string, NO_FLAGS); 317 StringToDouble(isolate()->unicode_cache(), *name_string, NO_FLAGS);
318 if (!std::isnan(d)) { 318 if (!std::isnan(d)) {
319 if (String::Equals(isolate()->factory()->minus_zero_string(),
320 name_string))
321 return true;
322
319 Factory* factory = isolate()->factory(); 323 Factory* factory = isolate()->factory();
320 Handle<Object> num = factory->NewNumber(d); 324 Handle<Object> num = factory->NewNumber(d);
321 Handle<String> roundtrip_string = factory->NumberToString(num); 325 Handle<String> roundtrip_string = factory->NumberToString(num);
322 if (String::Equals(name_string, roundtrip_string)) return true; 326 if (String::Equals(name_string, roundtrip_string)) return true;
323 } 327 }
324 } 328 }
325 } 329 }
326 return false; 330 return false;
327 } 331 }
328 332
329 333
330 void LookupIterator::InternalizeName() { 334 void LookupIterator::InternalizeName() {
331 if (name_->IsUniqueName()) return; 335 if (name_->IsUniqueName()) return;
332 name_ = factory()->InternalizeString(Handle<String>::cast(name_)); 336 name_ = factory()->InternalizeString(Handle<String>::cast(name_));
333 } 337 }
334 } } // namespace v8::internal 338 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap/heap.h ('k') | test/mjsunit/harmony/typedarrays.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698