Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 670623003: Handle property name "-0" correctly for typed arrays. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Handle property name "-0" correctly for typed arrays. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24768

Patch Set 1 #

Patch Set 2 : One more test #

Patch Set 3 : And another test for sloppy mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL, updated per ES6 spec.
6 years, 2 months ago (2014-10-21 11:00:01 UTC) #1
rossberg
lgtm
6 years, 2 months ago (2014-10-21 11:51:57 UTC) #2
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-21 11:54:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698