net/quic/quic_server_session.cc - Issue 670533004: Fixes two div by zero bugs in QUIC's BBR pacing code that caused server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_server_session.cc

Issue 670533004: Fixes two div by zero bugs in QUIC's BBR pacing code that caused server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Simplify_QuicUnackedPacketMap_77986449

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_server_session.cc

diff --git a/net/quic/quic_server_session.cc b/net/quic/quic_server_session.cc

index f2967a5998a15cb3e3fcb6ef6290e49a2f0ece27..c55496e7a517aaacf9f6fffa030670213072284a 100644

--- a/net/quic/quic_server_session.cc

+++ b/net/quic/quic_server_session.cc

@@ -122,7 +122,7 @@ void QuicServerSession::OnCongestionWindowChange(QuicTime now) {

cached_network_params.set_max_bandwidth_timestamp_seconds(

max_bandwidth_timestamp);

cached_network_params.set_min_rtt_ms(

- sent_packet_manager.GetRttStats()->min_rtt().ToMilliseconds());

+ sent_packet_manager.GetRttStats()->MinRtt().ToMilliseconds());

cached_network_params.set_previous_connection_state(

bandwidth_recorder.EstimateRecordedDuringSlowStart()

? CachedNetworkParameters::SLOW_START

« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/tools/quic/quic_server_session.cc » ('j') | no next file with comments »