net/quic/quic_sent_packet_manager_test.cc - Issue 670533004: Fixes two div by zero bugs in QUIC's BBR pacing code that caused server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 670533004: Fixes two div by zero bugs in QUIC's BBR pacing code that caused server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Simplify_QuicUnackedPacketMap_77986449

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager_test.cc

diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc

index 4f6d1b0849388dc4962b556645603f79c42994db..d3f031253ccd04a6b8c28afb08d12d03a9a19619 100644

--- a/net/quic/quic_sent_packet_manager_test.cc

+++ b/net/quic/quic_sent_packet_manager_test.cc

@@ -1036,7 +1036,7 @@ TEST_F(QuicSentPacketManagerTest, ResetRecentMinRTTWithEmptyWindow) {

QuicSentPacketManagerPeer::GetRttStats(&manager_)->UpdateRtt(

min_rtt, QuicTime::Delta::Zero(), QuicTime::Zero());

EXPECT_EQ(min_rtt,

- QuicSentPacketManagerPeer::GetRttStats(&manager_)->min_rtt());

+ QuicSentPacketManagerPeer::GetRttStats(&manager_)->MinRtt());

EXPECT_EQ(min_rtt,

QuicSentPacketManagerPeer::GetRttStats(

&manager_)->recent_min_rtt());

@@ -1063,7 +1063,7 @@ TEST_F(QuicSentPacketManagerTest, ResetRecentMinRTTWithEmptyWindow) {

manager_.OnIncomingAck(ack_frame, clock_.Now());

EXPECT_EQ(min_rtt,

- QuicSentPacketManagerPeer::GetRttStats(&manager_)->min_rtt());

+ QuicSentPacketManagerPeer::GetRttStats(&manager_)->MinRtt());

EXPECT_EQ(QuicTime::Delta::FromMilliseconds(100),

QuicSentPacketManagerPeer::GetRttStats(

&manager_)->recent_min_rtt());

« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_server_session.cc » ('j') | no next file with comments »