Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 670503002: Timeline: add layer details view (Closed)

Created:
6 years, 2 months ago by caseq
Modified:
6 years, 2 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Timeline: add layer details view This brings layer details view from Layers panel to Timeline's layer tree view. Also: - fixed trace layer import to include compositing reasons from trace; - show compositing traces as a list of user-friendly (long) strings. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -215 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
D Source/devtools/front_end/layers/LayerDetailsView.js View 1 chunk +0 lines, -198 lines 0 comments Download
M Source/devtools/front_end/layers/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/LayerTreeModel.js View 3 chunks +4 lines, -3 lines 0 comments Download
A + Source/devtools/front_end/timeline/LayerDetailsView.js View 2 chunks +8 lines, -10 lines 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineLayersView.js View 3 chunks +7 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timelinePanel.css View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caseq
6 years, 2 months ago (2014-10-20 14:15:07 UTC) #2
pfeldman
lgtm
6 years, 2 months ago (2014-10-20 14:58:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670503002/1
6 years, 2 months ago (2014-10-20 17:19:37 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:26:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184010

Powered by Google App Engine
This is Rietveld 408576698