Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: Source/devtools/front_end/timeline/TimelineLayersView.js

Issue 670503002: Timeline: add layer details view (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/Layers3DView.js ('k') | Source/devtools/front_end/timeline/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineLayersView.js
diff --git a/Source/devtools/front_end/timeline/TimelineLayersView.js b/Source/devtools/front_end/timeline/TimelineLayersView.js
index 14166d9b2a434f6e5cbd9c77046dd0d7174045e0..9ac1a068e9e8a3ad8ae6a662ae6a5530baffc1d0 100644
--- a/Source/devtools/front_end/timeline/TimelineLayersView.js
+++ b/Source/devtools/front_end/timeline/TimelineLayersView.js
@@ -11,6 +11,8 @@
WebInspector.TimelineLayersView = function()
{
WebInspector.SplitView.call(this, true, false, "timelineLayersView");
+ this._rightSplitView = new WebInspector.SplitView(true, true, "timelineLayersViewDetails");
+ this._rightSplitView.show(this.mainElement());
this._paintTiles = [];
@@ -25,7 +27,10 @@ WebInspector.TimelineLayersView = function()
this._layers3DView.addEventListener(WebInspector.Layers3DView.Events.ObjectSelected, this._onObjectSelected, this);
this._layers3DView.addEventListener(WebInspector.Layers3DView.Events.ObjectHovered, this._onObjectHovered, this);
this._layers3DView.addEventListener(WebInspector.Layers3DView.Events.JumpToPaintEventRequested, this._jumpToPaintEvent, this);
- this._layers3DView.show(this.mainElement());
+ this._layers3DView.show(this._rightSplitView.mainElement());
+
+ this._layerDetailsView = new WebInspector.LayerDetailsView();
+ this._layerDetailsView.show(this._rightSplitView.sidebarElement());
}
WebInspector.TimelineLayersView.prototype = {
@@ -151,6 +156,7 @@ WebInspector.TimelineLayersView.prototype = {
this._toggleNodeHighlight(layer ? layer.nodeForSelfOrAncestor() : null);
this._layerTreeOutline.selectLayer(layer);
this._layers3DView.selectObject(activeObject);
+ this._layerDetailsView.setObject(activeObject);
},
/**
« no previous file with comments | « Source/devtools/front_end/timeline/Layers3DView.js ('k') | Source/devtools/front_end/timeline/module.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698