<address> elements should have AXRoleDescription of 'address'

<address> elements should have AXRoleDescription of 'address'

According to latest editor spec http://rawgit.com/w3c/html-api-map/master/index.html

Recommended AXRoleDescription of "address" to disambiguate
from "contentinfo" landmark role for address element.

BUG=169577
Committed: https://crrev.com/b6894d59ad9f364d44b0609d0dda67a3f9d673ef
Cr-Commit-Position: refs/heads/master@{#301671}

[shreeramk, 2014-10-20 14:33:10]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[shreeramk, 2014-10-20 14:33:10]

Please review. 

Thanks!

[dmazzoni, 2014-10-20 16:31:55]

https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
File content/app/strings/content_strings.grd (right):

https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
content/app/strings/content_strings.grd:364: <message
name="IDS_AX_ROLE_CONTENT_INFO" desc="accessibility role description for
contentinfo">
As before, the name and description of the message should match the text to be
translated. The translators are not going to understand what "contentinfo" is,
or its relationship to "address".

[shreeramk, 2014-10-20 17:16:29]

On 2014/10/20 16:31:55, dmazzoni wrote:
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> File content/app/strings/content_strings.grd (right):
> 
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> content/app/strings/content_strings.grd:364: <message
> name="IDS_AX_ROLE_CONTENT_INFO" desc="accessibility role description for
> contentinfo">
> As before, the name and description of the message should match the text to be
> translated. The translators are not going to understand what "contentinfo" is,
> or its relationship to "address".

Then to match and make the translator understand. Following can be used:

name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for address"

Is this correct/fine?

[dmazzoni, 2014-10-20 17:21:37]

On 2014/10/20 17:16:29, shreeramk wrote:
> On 2014/10/20 16:31:55, dmazzoni wrote:
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > File content/app/strings/content_strings.grd (right):
> > 
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > content/app/strings/content_strings.grd:364: <message
> > name="IDS_AX_ROLE_CONTENT_INFO" desc="accessibility role description for
> > contentinfo">
> > As before, the name and description of the message should match the text to
be
> > translated. The translators are not going to understand what "contentinfo"
is,
> > or its relationship to "address".
> 
> Then to match and make the translator understand. Following can be used:
> 
> name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for
address"
> 
> Is this correct/fine?

Yes.

This is fine - but it's often better to add more information for translators if
the word is ambiguous. Here "address" does not mean "web address (url)", but "a
section of the page containing contact information in the form of a postal
address".

[shreeramk, 2014-10-20 17:30:27]

On 2014/10/20 17:21:37, dmazzoni wrote:
> On 2014/10/20 17:16:29, shreeramk wrote:
> > On 2014/10/20 16:31:55, dmazzoni wrote:
> > >
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > > File content/app/strings/content_strings.grd (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > > content/app/strings/content_strings.grd:364: <message
> > > name="IDS_AX_ROLE_CONTENT_INFO" desc="accessibility role description for
> > > contentinfo">
> > > As before, the name and description of the message should match the text
to
> be
> > > translated. The translators are not going to understand what "contentinfo"
> is,
> > > or its relationship to "address".
> > 
> > Then to match and make the translator understand. Following can be used:
> > 
> > name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for
> address"
> > 
> > Is this correct/fine?
> 
> Yes.
> 
> This is fine - but it's often better to add more information for translators
if
> the word is ambiguous. Here "address" does not mean "web address (url)", but
"a
> section of the page containing contact information in the form of a postal
> address".

Ok. Now I think I am getting this translator related fixes properly. I was not
completely clear on it.

I think this would be more clear/unambiguous.

name="IDS_AX_ROLE_CONTACT_INFORMATION" and desc="accessibility role description
for contact information"

[dmazzoni, 2014-10-20 17:36:34]

On 2014/10/20 17:30:27, shreeramk wrote:
> On 2014/10/20 17:21:37, dmazzoni wrote:
> > On 2014/10/20 17:16:29, shreeramk wrote:
> > > On 2014/10/20 16:31:55, dmazzoni wrote:
> > > >
> > >
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > > > File content/app/strings/content_strings.grd (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > > > content/app/strings/content_strings.grd:364: <message
> > > > name="IDS_AX_ROLE_CONTENT_INFO" desc="accessibility role description for
> > > > contentinfo">
> > > > As before, the name and description of the message should match the text
> to
> > be
> > > > translated. The translators are not going to understand what
"contentinfo"
> > is,
> > > > or its relationship to "address".
> > > 
> > > Then to match and make the translator understand. Following can be used:
> > > 
> > > name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for
> > address"
> > > 
> > > Is this correct/fine?
> > 
> > Yes.
> > 
> > This is fine - but it's often better to add more information for translators
> if
> > the word is ambiguous. Here "address" does not mean "web address (url)", but
> "a
> > section of the page containing contact information in the form of a postal
> > address".
> 
> Ok. Now I think I am getting this translator related fixes properly. I was not
> completely clear on it.
> 
> I think this would be more clear/unambiguous.
> 
> name="IDS_AX_ROLE_CONTACT_INFORMATION" and desc="accessibility role
description
> for contact information"

That implies that someone should translate the phrase "contact information" into
their language. We want them to translate the word "address" - but if there are
multiple meaning of "address", they should pick the one that they'd use when
talking about a person's contact information, as opposed to a web address.

How about:

name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for an
address (as in a person's contact information)"

[shreeramk, 2014-10-20 17:41:33]

On 2014/10/20 17:36:34, dmazzoni wrote:
> On 2014/10/20 17:30:27, shreeramk wrote:
> > On 2014/10/20 17:21:37, dmazzoni wrote:
> > > On 2014/10/20 17:16:29, shreeramk wrote:
> > > > On 2014/10/20 16:31:55, dmazzoni wrote:
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > > > > File content/app/strings/content_strings.grd (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/670493002/diff/1/content/app/strings/content_...
> > > > > content/app/strings/content_strings.grd:364: <message
> > > > > name="IDS_AX_ROLE_CONTENT_INFO" desc="accessibility role description
for
> > > > > contentinfo">
> > > > > As before, the name and description of the message should match the
text
> > to
> > > be
> > > > > translated. The translators are not going to understand what
> "contentinfo"
> > > is,
> > > > > or its relationship to "address".
> > > > 
> > > > Then to match and make the translator understand. Following can be used:
> > > > 
> > > > name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for
> > > address"
> > > > 
> > > > Is this correct/fine?
> > > 
> > > Yes.
> > > 
> > > This is fine - but it's often better to add more information for
translators
> > if
> > > the word is ambiguous. Here "address" does not mean "web address (url)",
but
> > "a
> > > section of the page containing contact information in the form of a postal
> > > address".
> > 
> > Ok. Now I think I am getting this translator related fixes properly. I was
not
> > completely clear on it.
> > 
> > I think this would be more clear/unambiguous.
> > 
> > name="IDS_AX_ROLE_CONTACT_INFORMATION" and desc="accessibility role
> description
> > for contact information"
> 
> That implies that someone should translate the phrase "contact information"
into
> their language. We want them to translate the word "address" - but if there
are
> multiple meaning of "address", they should pick the one that they'd use when
> talking about a person's contact information, as opposed to a web address.

  Ok...:)

> How about:
> 
> name="IDS_AX_ROLE_ADDRESS" and desc="accessibility role description for an
> address (as in a person's contact information)"

Yes. This looks fine.

I ll update the CL with mentioned changes.

Thanks a lot for the guidance. :)

[shreeramk, 2014-10-20 17:46:40]

@Dominic: PTAL!

Thanks :)

[shreeramk, 2014-10-20 17:51:34]

shreeram.k@samsung.com changed reviewers:
+ jam@chromium.org

[shreeramk, 2014-10-20 17:51:34]

shreeram.k@samsung.com changed required reviewers:
+ dmazzoni@chromium.org, jam@chromium.org

[jam, 2014-10-20 20:19:51]

lgtm

[shreeramk, 2014-10-21 18:50:37]

@Dominic: I think all required changes has been done in last Patchset.
PTAL. 

Thanks :)

[shreeramk, 2014-10-28 17:40:24]

On 2014/10/21 18:50:37, shreeramk_OOO_2nd_Nov wrote:
> @Dominic: I think all required changes has been done in last Patchset.
> PTAL. 
> 
> Thanks :)

@Dominic: Could you please review this CL as well?

Thanks

[dmazzoni, 2014-10-28 17:49:38]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-10-28 17:49:39]

lgtm

[commit-bot: I haz the power, 2014-10-28 17:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670493002/40001

[commit-bot: I haz the power, 2014-10-28 18:50:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-28 18:51:09]

Patchset 3 (id:??) landed as
https://crrev.com/b6894d59ad9f364d44b0609d0dda67a3f9d673ef
Cr-Commit-Position: refs/heads/master@{#301671}