Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 670493002: <address> elements should have AXRoleDescription of 'address' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing changes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <execinfo.h> 5 #include <execinfo.h>
6 6
7 #import "content/browser/accessibility/browser_accessibility_cocoa.h" 7 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 // TODO(dtseng): This is not localized; see crbug/84814. 571 // TODO(dtseng): This is not localized; see crbug/84814.
572 return base::SysUTF8ToNSString(role); 572 return base::SysUTF8ToNSString(role);
573 } 573 }
574 } 574 }
575 } 575 }
576 576
577 switch([self internalRole]) { 577 switch([self internalRole]) {
578 case ui::AX_ROLE_BANNER: 578 case ui::AX_ROLE_BANNER:
579 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 579 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
580 IDS_AX_ROLE_BANNER)); 580 IDS_AX_ROLE_BANNER));
581 break; 581 case ui::AX_ROLE_CONTENT_INFO:
582 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
583 IDS_AX_ROLE_ADDRESS));
582 case ui::AX_ROLE_FOOTER: 584 case ui::AX_ROLE_FOOTER:
583 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 585 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
584 IDS_AX_ROLE_FOOTER)); 586 IDS_AX_ROLE_FOOTER));
585 case ui::AX_ROLE_SPIN_BUTTON: 587 case ui::AX_ROLE_SPIN_BUTTON:
586 // This control is similar to what VoiceOver calls a "stepper". 588 // This control is similar to what VoiceOver calls a "stepper".
587 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 589 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
588 IDS_AX_ROLE_STEPPER)); 590 IDS_AX_ROLE_STEPPER));
589 case ui::AX_ROLE_TOGGLE_BUTTON: 591 case ui::AX_ROLE_TOGGLE_BUTTON:
590 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 592 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
591 IDS_AX_ROLE_TOGGLE_BUTTON)); 593 IDS_AX_ROLE_TOGGLE_BUTTON));
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
1450 return [super hash]; 1452 return [super hash];
1451 return browserAccessibility_->GetId(); 1453 return browserAccessibility_->GetId();
1452 } 1454 }
1453 1455
1454 - (BOOL)accessibilityShouldUseUniqueId { 1456 - (BOOL)accessibilityShouldUseUniqueId {
1455 return YES; 1457 return YES;
1456 } 1458 }
1457 1459
1458 @end 1460 @end
1459 1461
OLDNEW
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/test/data/accessibility/address-expected-mac.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698