Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 670463004: Make a platform-independent ToolbarActionViewController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/page_action_image_view.h
diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.h b/chrome/browser/ui/views/location_bar/page_action_image_view.h
index 576468bb0668543591642117b51421e5a2722e49..5f3785cd607c0af8b53ff92754d105d0a95e4827 100644
--- a/chrome/browser/ui/views/location_bar/page_action_image_view.h
+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.h
@@ -8,12 +8,13 @@
#include <string>
#include "base/memory/scoped_ptr.h"
-#include "chrome/browser/ui/views/extensions/extension_action_view_controller.h"
-#include "chrome/browser/ui/views/toolbar/toolbar_action_view_delegate.h"
+#include "chrome/browser/ui/extensions/extension_action_view_controller.h"
+#include "chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h"
#include "ui/views/controls/image_view.h"
class Browser;
class ExtensionAction;
+class ExtensionActionViewController;
class LocationBarView;
namespace content {
@@ -22,13 +23,13 @@ class WebContents;
// PageActionImageView is used by the LocationBarView to display the icon for a
// given PageAction and notify the extension when the icon is clicked.
-class PageActionImageView : public ToolbarActionViewDelegate,
+class PageActionImageView : public ToolbarActionViewDelegateViews,
public views::ImageView {
public:
PageActionImageView(LocationBarView* owner,
ExtensionAction* page_action,
Browser* browser);
- virtual ~PageActionImageView();
+ ~PageActionImageView() override;
void set_preview_enabled(bool preview_enabled) {
preview_enabled_ = preview_enabled;
@@ -41,12 +42,12 @@ class PageActionImageView : public ToolbarActionViewDelegate,
}
// Overridden from views::View:
- virtual const char* GetClassName() const override;
- virtual void GetAccessibleState(ui::AXViewState* state) override;
- virtual bool OnMousePressed(const ui::MouseEvent& event) override;
- virtual void OnMouseReleased(const ui::MouseEvent& event) override;
- virtual bool OnKeyPressed(const ui::KeyEvent& event) override;
- virtual void OnGestureEvent(ui::GestureEvent* event) override;
+ const char* GetClassName() const override;
+ void GetAccessibleState(ui::AXViewState* state) override;
+ bool OnMousePressed(const ui::MouseEvent& event) override;
+ void OnMouseReleased(const ui::MouseEvent& event) override;
+ bool OnKeyPressed(const ui::KeyEvent& event) override;
+ void OnGestureEvent(ui::GestureEvent* event) override;
// Called to notify the PageAction that it should determine whether to be
// visible or hidden. |contents| is the WebContents that is active.
@@ -56,21 +57,20 @@ class PageActionImageView : public ToolbarActionViewDelegate,
static const char kViewClassName[];
// Overridden from View.
- virtual void PaintChildren(gfx::Canvas* canvas,
- const views::CullSet& cull_set) override;
-
- // ToolbarActionViewDelegate:
- virtual void OnIconUpdated() override;
- virtual views::View* GetAsView() override;
- virtual bool IsShownInMenu() override;
- virtual views::FocusManager* GetFocusManagerForAccelerator() override;
- virtual views::Widget* GetParentForContextMenu() override;
- virtual ExtensionActionViewController* GetPreferredPopupViewController()
- override;
- virtual views::View* GetReferenceViewForPopup() override;
- virtual views::MenuButton* GetContextMenuButton() override;
- virtual content::WebContents* GetCurrentWebContents() const override;
- virtual void HideActivePopup() override;
+ void PaintChildren(gfx::Canvas* canvas,
+ const views::CullSet& cull_set) override;
+
+ // ToolbarActionViewDelegateViews:
+ void UpdateState() override;
+ views::View* GetAsView() override;
+ bool IsShownInMenu() override;
+ views::FocusManager* GetFocusManagerForAccelerator() override;
+ views::Widget* GetParentForContextMenu() override;
+ ToolbarActionViewController* GetPreferredPopupViewController() override;
+ views::View* GetReferenceViewForPopup() override;
+ views::MenuButton* GetContextMenuButton() override;
+ content::WebContents* GetCurrentWebContents() const override;
+ void HideActivePopup() override;
// The controller for this ExtensionAction view.
scoped_ptr<ExtensionActionViewController> view_controller_;

Powered by Google App Engine
This is Rietveld 408576698