chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 670463004: Make a platform-independent ToolbarActionViewController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 670463004: Make a platform-independent ToolbarActionViewController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_action_view_controller.cc ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index 1eee3d13a50e7aeb9a103e55ed82c28404b42f60..f842e321f8c59167d715e73024705889e6e65ae2 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -1313,7 +1313,7 @@ bool LocationBarView::ShowPageActionPopup(

*extension);

DCHECK(extension_action);

return GetPageActionView(extension_action)->image_view()->view_controller()->

- ExecuteAction(ExtensionPopup::SHOW, grant_tab_permissions);

+ ExecuteAction(grant_tab_permissions);

}

void LocationBarView::UpdateOpenPDFInReaderPrompt() {

@@ -1391,7 +1391,7 @@ void LocationBarView::TestPageActionPressed(size_t index) {

if (page_action_views_[i]->visible()) {

if (current == index) {

page_action_views_[i]->image_view()->view_controller()->

- ExecuteAction(ExtensionPopup::SHOW, true);

+ ExecuteAction(true);

return;

}

++current;