Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 670433005: Cleanup: Use default constructor for WebCryptoKey rather than createNull() factory method. (Closed)

Created:
6 years, 2 months ago by eroman
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Use default constructor for WebCryptoKey rather than createNull() factory method. BUG=425251 Committed: https://crrev.com/7b9591ab655583d45dd2483e70dc2ea0baee7b56 Cr-Commit-Position: refs/heads/master@{#300507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -125 lines) Patch
M content/child/webcrypto/generate_key_result.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/test/aes_cbc_unittest.cc View 37 chunks +38 lines, -38 lines 0 comments Download
M content/child/webcrypto/test/aes_gcm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/test/aes_kw_unittest.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M content/child/webcrypto/test/hmac_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/child/webcrypto/test/rsa_oaep_unittest.cc View 16 chunks +19 lines, -19 lines 0 comments Download
M content/child/webcrypto/test/rsa_ssa_unittest.cc View 23 chunks +30 lines, -30 lines 0 comments Download
M content/child/webcrypto/test/test_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/webcrypto_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
eroman
6 years, 2 months ago (2014-10-20 20:13:40 UTC) #2
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-10-20 22:44:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670433005/1
6 years, 2 months ago (2014-10-20 22:47:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/14449) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/9467) linux_chromium_gn_rel ...
6 years, 2 months ago (2014-10-20 23:06:45 UTC) #7
eroman
(Needs to wait until Blink rolls)
6 years, 2 months ago (2014-10-20 23:17:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670433005/1
6 years, 2 months ago (2014-10-21 16:25:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 17:13:14 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:14:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b9591ab655583d45dd2483e70dc2ea0baee7b56
Cr-Commit-Position: refs/heads/master@{#300507}

Powered by Google App Engine
This is Rietveld 408576698