content/child/webcrypto/openssl/rsa_key_openssl.cc - Issue 670433005: Cleanup: Use default constructor for WebCryptoKey rather than createNull() factory method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/openssl/rsa_key_openssl.cc

Issue 670433005: Cleanup: Use default constructor for WebCryptoKey rather than createNull() factory method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webcrypto/openssl/rsa_key_openssl.cc

diff --git a/content/child/webcrypto/openssl/rsa_key_openssl.cc b/content/child/webcrypto/openssl/rsa_key_openssl.cc

index 13b2333e60294107a2f9f580e9f9aca45924df51..b93de69f0fa66a8ce5716786dbf543aa3d9f7c0a 100644

--- a/content/child/webcrypto/openssl/rsa_key_openssl.cc

+++ b/content/child/webcrypto/openssl/rsa_key_openssl.cc

@@ -284,8 +284,8 @@ Status RsaHashedAlgorithm::GenerateKey(

return Status::OperationError();

}

- blink::WebCryptoKey public_key = blink::WebCryptoKey::createNull();

- blink::WebCryptoKey private_key = blink::WebCryptoKey::createNull();

+ blink::WebCryptoKey public_key;

+ blink::WebCryptoKey private_key;

// Note that extractable is unconditionally set to true. This is because per

// the WebCrypto spec generated public keys are always public.

« no previous file with comments | « content/child/webcrypto/generate_key_result.cc ('k') | content/child/webcrypto/test/aes_cbc_unittest.cc » ('j') | no next file with comments »