Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 670303003: Use DCHECK_EQ() when comparing TimeDeltas. (Closed)

Created:
6 years, 2 months ago by Adam Rice
Modified:
6 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@s-w-r-mmenke-fixes
Project:
chromium
Visibility:
Public.

Description

Use DCHECK_EQ() when comparing TimeDeltas. This CL is a part of https://codereview.chromium.org/665023002/ ("Post-commit fixes for "stale-while-revalidate..."") that has been separated into a separate CL because it depends on https://codereview.chromium.org/669083002/ ("Add logging support for base::Time* types."). BUG=348877 Committed: https://crrev.com/eb1504475d05411b479912b2c896862221f21d51 Cr-Commit-Position: refs/heads/master@{#302065}

Patch Set 1 #

Patch Set 2 : Merge latest changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/http/http_response_headers.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Adam Rice
6 years, 1 month ago (2014-10-29 10:24:53 UTC) #2
mmenke
LGTM
6 years, 1 month ago (2014-10-29 12:44:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670303003/20001
6 years, 1 month ago (2014-10-30 09:52:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 10:43:15 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 10:43:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb1504475d05411b479912b2c896862221f21d51
Cr-Commit-Position: refs/heads/master@{#302065}

Powered by Google App Engine
This is Rietveld 408576698