Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 669083002: Add logging support for base::Time* types. (Closed)

Created:
6 years, 2 months ago by Adam Rice
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add logging support for base::Time* types. Define operator<<(ostream&,Time) to permit Time, TimeDelta and TimeTicks types to be used in logging assertions such as DCHECK_EQ(). BUG=425941 TEST=base_unittests Committed: https://crrev.com/fa874fd422dd79886729d6884b032b44572c43ee Cr-Commit-Position: refs/heads/master@{#301815}

Patch Set 1 #

Patch Set 2 : Add missing <string> include. #

Total comments: 6

Patch Set 3 : Format TimeTicks as relative seconds. #

Patch Set 4 : Change output for TimeTicks to bogo-microseconds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -3 lines) Patch
M base/time/time.h View 4 chunks +15 lines, -0 lines 0 comments Download
M base/time/time.cc View 1 2 3 4 chunks +31 lines, -0 lines 0 comments Download
M base/time/time_unittest.cc View 1 2 3 3 chunks +102 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
Adam Rice
6 years, 2 months ago (2014-10-22 10:29:54 UTC) #2
mmenke
LGTM
6 years, 2 months ago (2014-10-22 18:42:38 UTC) #3
Adam Rice
+rvargas for base/ OWNERS.
6 years, 2 months ago (2014-10-23 00:48:56 UTC) #5
rvargas (doing something else)
https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc File base/time/time.cc (right): https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc#newcode278 base/time/time.cc:278: // This function formats a TimeTicks object as if ...
6 years, 2 months ago (2014-10-23 02:36:39 UTC) #6
Adam Rice
https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc File base/time/time.cc (right): https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc#newcode278 base/time/time.cc:278: // This function formats a TimeTicks object as if ...
6 years, 2 months ago (2014-10-23 03:42:02 UTC) #7
rvargas (doing something else)
https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc File base/time/time.cc (right): https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc#newcode278 base/time/time.cc:278: // This function formats a TimeTicks object as if ...
6 years, 2 months ago (2014-10-23 19:30:44 UTC) #8
Adam Rice
https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc File base/time/time.cc (right): https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc#newcode278 base/time/time.cc:278: // This function formats a TimeTicks object as if ...
6 years, 2 months ago (2014-10-24 04:05:39 UTC) #9
rvargas (doing something else)
https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc File base/time/time.cc (right): https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc#newcode278 base/time/time.cc:278: // This function formats a TimeTicks object as if ...
6 years, 2 months ago (2014-10-24 23:24:18 UTC) #10
Adam Rice
https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc File base/time/time.cc (right): https://codereview.chromium.org/669083002/diff/20001/base/time/time.cc#newcode278 base/time/time.cc:278: // This function formats a TimeTicks object as if ...
6 years, 1 month ago (2014-10-28 05:43:12 UTC) #11
rvargas (doing something else)
lgtm
6 years, 1 month ago (2014-10-29 09:03:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669083002/60001
6 years, 1 month ago (2014-10-29 10:24:50 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-29 11:35:54 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 11:36:42 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fa874fd422dd79886729d6884b032b44572c43ee
Cr-Commit-Position: refs/heads/master@{#301815}

Powered by Google App Engine
This is Rietveld 408576698