Issue 670223002: Revert of Update extension preference API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670223002: Revert of Update extension preference API. (Closed)

Created:
6 years, 2 months ago by grt (UTC plus 2)

Modified:
6 years, 2 months ago

Reviewers:
Bence, Marijn Kruisselbrink

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Update extension preference API. (patchset #2 id:160001 of https://codereview.chromium.org/652013002/) Reason for revert: Broke ExtensionPreferenceApiTest.Standard on multiple builders. Original issue's description: > Update extension preference API. > > Modify Boolean extension preference "networkPredictionEnabled" to interact with native browser preference |prefs::kNetworkPredictionOptions| instead of obsolete |prefs::kNetworkPredictionEnabled|. > > BUG=423748 > > Committed: https://crrev.com/2fcb4c342e0a05ab2b5449cc14e52d47a91ebf89 > Cr-Commit-Position: refs/heads/master@{#300723} TBR=mek@chromium.org,bnc@chromium.org NOTREECHECKS=true NOTRY=true BUG=423748 Committed: https://crrev.com/eae687a8855f4879158ed1138e95ce5a848c5307 Cr-Commit-Position: refs/heads/master@{#300751}

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -37 lines)			Patch
	M	chrome/browser/extensions/api/preference/preference_api.cc	View		6 chunks	+4 lines, -30 lines	0 comments	Download
	M	chrome/browser/extensions/api/preference/preference_apitest.cc	View		4 chunks	+3 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

grt (UTC plus 2)

Created Revert of Update extension preference API.

6 years, 2 months ago (2014-10-22 20:50:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670223002/1

6 years, 2 months ago (2014-10-22 20:52:50 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 20:56:15 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eae687a8855f4879158ed1138e95ce5a848c5307
Cr-Commit-Position: refs/heads/master@{#300751}