Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 670223002: Revert of Update extension preference API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_service.h" 5 #include "base/prefs/pref_service.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/extensions/extension_apitest.h" 9 #include "chrome/browser/extensions/extension_apitest.h"
10 #include "chrome/browser/net/prediction_options.h"
11 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
13 #include "chrome/common/chrome_switches.h" 12 #include "chrome/common/chrome_switches.h"
14 #include "chrome/common/pref_names.h" 13 #include "chrome/common/pref_names.h"
15 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
16 #include "components/translate/core/common/translate_pref_names.h" 15 #include "components/translate/core/common/translate_pref_names.h"
17 #include "content/public/browser/notification_service.h" 16 #include "content/public/browser/notification_service.h"
18 #include "extensions/browser/extension_registry.h" 17 #include "extensions/browser/extension_registry.h"
19 #include "extensions/browser/test_extension_registry_observer.h" 18 #include "extensions/browser/test_extension_registry_observer.h"
20 #include "extensions/test/extension_test_message_listener.h" 19 #include "extensions/test/extension_test_message_listener.h"
(...skipping 16 matching lines...) Expand all
37 const PrefService::Preference* pref = prefs->FindPreference( 36 const PrefService::Preference* pref = prefs->FindPreference(
38 prefs::kBlockThirdPartyCookies); 37 prefs::kBlockThirdPartyCookies);
39 ASSERT_TRUE(pref); 38 ASSERT_TRUE(pref);
40 EXPECT_TRUE(pref->IsExtensionControlled()); 39 EXPECT_TRUE(pref->IsExtensionControlled());
41 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 40 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
42 EXPECT_TRUE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled)); 41 EXPECT_TRUE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled));
43 EXPECT_FALSE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies)); 42 EXPECT_FALSE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies));
44 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing)); 43 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing));
45 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers)); 44 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers));
46 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate)); 45 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate));
47 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_DEFAULT, 46 EXPECT_TRUE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled));
48 prefs->GetInteger(prefs::kNetworkPredictionOptions));
49 EXPECT_TRUE(prefs->GetBoolean( 47 EXPECT_TRUE(prefs->GetBoolean(
50 password_manager::prefs::kPasswordManagerSavingEnabled)); 48 password_manager::prefs::kPasswordManagerSavingEnabled));
51 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 49 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
52 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 50 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
53 } 51 }
54 52
55 void CheckPreferencesCleared() { 53 void CheckPreferencesCleared() {
56 PrefService* prefs = profile_->GetPrefs(); 54 PrefService* prefs = profile_->GetPrefs();
57 const PrefService::Preference* pref = prefs->FindPreference( 55 const PrefService::Preference* pref = prefs->FindPreference(
58 prefs::kBlockThirdPartyCookies); 56 prefs::kBlockThirdPartyCookies);
59 ASSERT_TRUE(pref); 57 ASSERT_TRUE(pref);
60 EXPECT_FALSE(pref->IsExtensionControlled()); 58 EXPECT_FALSE(pref->IsExtensionControlled());
61 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 59 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
62 EXPECT_FALSE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled)); 60 EXPECT_FALSE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled));
63 EXPECT_TRUE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies)); 61 EXPECT_TRUE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies));
64 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing)); 62 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing));
65 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers)); 63 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers));
66 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate)); 64 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate));
67 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER, 65 EXPECT_FALSE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled));
68 prefs->GetInteger(prefs::kNetworkPredictionOptions));
69 EXPECT_FALSE(prefs->GetBoolean( 66 EXPECT_FALSE(prefs->GetBoolean(
70 password_manager::prefs::kPasswordManagerSavingEnabled)); 67 password_manager::prefs::kPasswordManagerSavingEnabled));
71 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 68 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
72 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 69 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
73 } 70 }
74 71
75 virtual void SetUpOnMainThread() override { 72 virtual void SetUpOnMainThread() override {
76 ExtensionApiTest::SetUpOnMainThread(); 73 ExtensionApiTest::SetUpOnMainThread();
77 74
78 // The browser might get closed later (and therefore be destroyed), so we 75 // The browser might get closed later (and therefore be destroyed), so we
(...skipping 26 matching lines...) Expand all
105 #define MAYBE_Standard Standard 102 #define MAYBE_Standard Standard
106 #endif 103 #endif
107 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) { 104 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) {
108 PrefService* prefs = profile_->GetPrefs(); 105 PrefService* prefs = profile_->GetPrefs();
109 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false); 106 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false);
110 prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false); 107 prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false);
111 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, true); 108 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, true);
112 prefs->SetBoolean(prefs::kEnableHyperlinkAuditing, false); 109 prefs->SetBoolean(prefs::kEnableHyperlinkAuditing, false);
113 prefs->SetBoolean(prefs::kEnableReferrers, false); 110 prefs->SetBoolean(prefs::kEnableReferrers, false);
114 prefs->SetBoolean(prefs::kEnableTranslate, false); 111 prefs->SetBoolean(prefs::kEnableTranslate, false);
115 prefs->SetInteger(prefs::kNetworkPredictionOptions, 112 prefs->SetBoolean(prefs::kNetworkPredictionEnabled, false);
116 chrome_browser_net::NETWORK_PREDICTION_NEVER);
117 prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled, 113 prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,
118 false); 114 false);
119 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); 115 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);
120 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false); 116 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);
121 117
122 const char kExtensionPath[] = "preference/standard"; 118 const char kExtensionPath[] = "preference/standard";
123 119
124 EXPECT_TRUE(RunExtensionSubtest(kExtensionPath, "test.html")) << message_; 120 EXPECT_TRUE(RunExtensionSubtest(kExtensionPath, "test.html")) << message_;
125 CheckPreferencesSet(); 121 CheckPreferencesSet();
126 122
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 319
324 // Test 6 - clearDefault 320 // Test 6 - clearDefault
325 EXPECT_TRUE(listener10.WaitUntilSatisfied()); // Regular ready 321 EXPECT_TRUE(listener10.WaitUntilSatisfied()); // Regular ready
326 EXPECT_TRUE(listener_incognito10.WaitUntilSatisfied()); // Incognito ready 322 EXPECT_TRUE(listener_incognito10.WaitUntilSatisfied()); // Incognito ready
327 listener10.Reply("ok"); 323 listener10.Reply("ok");
328 listener_incognito10.Reply("ok"); 324 listener_incognito10.Reply("ok");
329 325
330 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 326 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
331 EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message(); 327 EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message();
332 } 328 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698