Cut down SkBBH API more.

Cut down SkBBH API more.
  - The expected case is now a single bulk-load insert() call instead of N;
  - reserve() and flushDeferredInserts() can fold into insert() now;
  - SkBBH subclasses may take ownership of the bounds

This appears to be a performance no-op on both my Mac and N5.  I guess
even the simplest indirect branch predictor ("same as last time") can predict
the repeated virtual calls to SkBBH::insert() perfectly.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4477c3c0e6eb064772aefe8737425cd1c2ce557f

[mtklein, 2014-10-22 20:04:38]

mtklein@google.com changed reviewers:
+ mtklein@google.com, robertphillips@google.com

[mtklein, 2014-10-22 20:04:50]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-22 20:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/1

[commit-bot: I haz the power, 2014-10-22 20:05:35]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-23 02:05 UTC

[commit-bot: I haz the power, 2014-10-22 20:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 20:11:15]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[mtklein, 2014-10-23 15:21:23]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-23 15:21:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/20001

[commit-bot: I haz the power, 2014-10-23 15:21:55]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-23 21:21 UTC

[mtklein, 2014-10-23 16:37:37]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-23 16:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/40001

[commit-bot: I haz the power, 2014-10-23 16:38:46]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-23 22:38 UTC

[mtklein, 2014-10-23 19:27:59]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-23 19:28:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/60001

[commit-bot: I haz the power, 2014-10-23 19:28:27]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-24 01:28 UTC

[mtklein, 2014-10-23 19:35:08]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-23 19:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/80001

[commit-bot: I haz the power, 2014-10-23 19:35:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-24 01:35 UTC

[mtklein, 2014-10-23 19:54:33]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-23 19:55:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/100001

[commit-bot: I haz the power, 2014-10-23 19:55:43]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-24 01:55 UTC

[mtklein, 2014-10-23 20:04:19]

OK, should be ready for review / to land.

[commit-bot: I haz the power, 2014-10-24 01:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:55:52]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[robertphillips, 2014-10-24 18:52:45]

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp
File src/core/SkRTree.cpp (right):

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp#ne...
src/core/SkRTree.cpp:72: 
In this case the tree isn't empty. So I think this allocateNode will do bad
things.

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp#ne...
src/core/SkRTree.cpp:75: 
this-> ?

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp#ne...
src/core/SkRTree.cpp:91: if (1 == fCount) {
this-> ?

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp#n...
tests/PictureTest.cpp:1867: 
Where did we land re the style guide and virtual vs. SK_OVERRIDE?

[mtklein, 2014-10-24 19:05:49]

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp
File src/core/SkRTree.cpp (right):

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp#ne...
src/core/SkRTree.cpp:72: 
On 2014/10/24 18:52:45, robertphillips wrote:
> In this case the tree isn't empty. So I think this allocateNode will do bad
> things.

I've just asserted this->isEmpty() and deleted the non-empty path.

https://codereview.chromium.org/670213002/diff/100001/src/core/SkRTree.cpp#ne...
src/core/SkRTree.cpp:91: if (1 == fCount) {
On 2014/10/24 18:52:45, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp#n...
tests/PictureTest.cpp:1867: 
On 2014/10/24 18:52:45, robertphillips wrote:
> Where did we land re the style guide and virtual vs. SK_OVERRIDE?

Let's try.

[mtklein, 2014-10-24 19:06:59]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-24 19:07:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/120001

[commit-bot: I haz the power, 2014-10-24 19:07:29]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-25 01:07 UTC

[commit-bot: I haz the power, 2014-10-25 01:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-25 01:07:37]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[robertphillips, 2014-10-27 15:23:30]

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp#n...
tests/PictureTest.cpp:1867: 
I propose trying this in a different patch with possibly a wider review list.

[mtklein, 2014-10-27 15:36:45]

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/670213002/diff/100001/tests/PictureTest.cpp#n...
tests/PictureTest.cpp:1867: 
On 2014/10/27 15:23:30, robertphillips wrote:
> I propose trying this in a different patch with possibly a wider review list.

Done.

[mtklein, 2014-10-27 15:36:50]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-27 15:37:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670213002/140001

[commit-bot: I haz the power, 2014-10-27 15:37:50]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-27 21:37 UTC

[robertphillips, 2014-10-27 16:16:47]

lgtm

[commit-bot: I haz the power, 2014-10-27 17:27:20]

Committed patchset #8 (id:140001) as 4477c3c0e6eb064772aefe8737425cd1c2ce557f