Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: test/same-source-file-name/gyptest-shared.py

Issue 670063006: Stop checking for duplicate basenames (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: s/fails/succeeds/ per scottmg@ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/errors/gyptest-errors.py ('k') | test/same-source-file-name/gyptest-static.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 Google Inc. All rights reserved. 3 # Copyright (c) 2012 Google Inc. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """ 7 """
8 Checks that gyp fails on shared_library targets which have several files with 8 Checks that gyp succeeds on shared_library targets which have several files with
9 the same basename. 9 the same basename.
10 """ 10 """
11 11
12 import os 12 import os
13 13
14 import TestGyp 14 import TestGyp
15 15
16 test = TestGyp.TestGyp() 16 test = TestGyp.TestGyp()
17 17
18 # Fails by default for the compatibility with Visual C++ 2008 generator.
19 # TODO: Update expected behavior when these legacy generators are deprecated.
20 test.run_gyp('double-shared.gyp', chdir='src', status=1, stderr=None)
21
22 if ((test.format == 'msvs') and 18 if ((test.format == 'msvs') and
23 (int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)): 19 (int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)):
24 test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check', 20 test.run_gyp('double-shared.gyp',
25 chdir='src', status=0, stderr=None) 21 chdir='src', status=0, stderr=None)
26 else: 22 else:
27 test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check', 23 test.run_gyp('double-shared.gyp',
28 chdir='src') 24 chdir='src')
29 test.build('double-shared.gyp', test.ALL, chdir='src') 25 test.build('double-shared.gyp', test.ALL, chdir='src')
30 26
31 test.pass_test() 27 test.pass_test()
OLDNEW
« no previous file with comments | « test/errors/gyptest-errors.py ('k') | test/same-source-file-name/gyptest-static.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698