Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: test/same-source-file-name/gyptest-static.py

Issue 670063006: Stop checking for duplicate basenames (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: s/fails/succeeds/ per scottmg@ Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/same-source-file-name/gyptest-shared.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 Google Inc. All rights reserved. 3 # Copyright (c) 2012 Google Inc. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """ 7 """
8 Checks that gyp fails on static_library targets which have several files with 8 Checks that gyp succeeds on static_library targets which have several files with
9 the same basename. 9 the same basename.
10 """ 10 """
11 11
12 import os 12 import os
13 import sys 13 import sys
14 14
15 import TestGyp 15 import TestGyp
16 16
17 test = TestGyp.TestGyp() 17 test = TestGyp.TestGyp()
18 18
19 # Fails by default for the compatibility with legacy generators such as
20 # VCProj generator for Visual C++ 2008 and Makefile generator on Mac.
21 # TODO: Update expected behavior when these legacy generators are deprecated.
22 test.run_gyp('double-static.gyp', chdir='src', status=1, stderr=None)
23
24 if ((test.format == 'make' and sys.platform == 'darwin') or 19 if ((test.format == 'make' and sys.platform == 'darwin') or
25 (test.format == 'msvs' and 20 (test.format == 'msvs' and
26 int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)): 21 int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)):
27 test.run_gyp('double-static.gyp', '--no-duplicate-basename-check', 22 test.run_gyp('double-static.gyp',
28 chdir='src', status=1, stderr=None) 23 chdir='src', status=1, stderr=None)
29 else: 24 else:
30 test.run_gyp('double-static.gyp', '--no-duplicate-basename-check', 25 test.run_gyp('double-static.gyp',
31 chdir='src') 26 chdir='src')
32 test.build('double-static.gyp', test.ALL, chdir='src') 27 test.build('double-static.gyp', test.ALL, chdir='src')
33 28
34 test.pass_test() 29 test.pass_test()
OLDNEW
« no previous file with comments | « test/same-source-file-name/gyptest-shared.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698