ipc/mojo/ipc_mojo_perftest.cc - Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/mojo/ipc_mojo_perftest.cc

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/mojo/ipc_mojo_perftest.cc

diff --git a/ipc/mojo/ipc_mojo_perftest.cc b/ipc/mojo/ipc_mojo_perftest.cc

index 29e78397ce2b30397826b304c00e2d9a7f17390a..dca405ee1dbac7f41da9eb462b585d5ac5ccaf82 100644

--- a/ipc/mojo/ipc_mojo_perftest.cc

+++ b/ipc/mojo/ipc_mojo_perftest.cc

@@ -29,7 +29,7 @@

MojoChannelPerfTest();

- scoped_ptr<IPC::ChannelFactory> CreateChannelFactory(

+ virtual scoped_ptr<IPC::ChannelFactory> CreateChannelFactory(

const IPC::ChannelHandle& handle,

base::TaskRunner* runner) override {

host_.reset(new IPC::ChannelMojoHost(task_runner()));

@@ -37,7 +37,7 @@

handle);

}

- bool DidStartClient() override {

+ virtual bool DidStartClient() override {

bool ok = IPCTestBase::DidStartClient();

DCHECK(ok);

host_->OnClientLaunched(client_process());

@@ -73,7 +73,8 @@

MojoTestClient();

- scoped_ptr<IPC::Channel> CreateChannel(IPC::Listener* listener) override;

+ virtual scoped_ptr<IPC::Channel> CreateChannel(

+ IPC::Listener* listener) override;

};

MojoTestClient::MojoTestClient() {

« no previous file with comments | « ipc/mojo/ipc_mojo_bootstrap_unittest.cc ('k') | ipc/sync_socket_unittest.cc » ('j') | no next file with comments »