[Downloads] Cleanup DownloadResourceHandler

content/browser/download/download_stats.h

Index: content/browser/download/download_stats.h
diff --git a/content/browser/download/download_stats.h b/content/browser/download/download_stats.h
index 9a9b1f28b4529e6253cc092f4c447ee4ef2e334e..293f0faad048789a6e97a3adedca63b879083e62 100644
--- a/content/browser/download/download_stats.h
+++ b/content/browser/download/download_stats.h
@@ -165,10 +165,12 @@ void RecordBandwidth(double actual_bandwidth, double potential_bandwidth);
 void RecordOpen(const base::Time& end, bool first);
 
 // Record whether or not the server accepts ranges, and the download size. Also
-// counts if a strong ETag is supplied. The combination of range request support
-// and ETag indicates downloads that are candidates for partial resumption.
-void RecordAcceptsRanges(const std::string& accepts_ranges, int64 download_len,
-                         const std::string& etag);
+// counts if a strong validator is supplied. The combination of range request
+// support and ETag indicates downloads that are candidates for partial
+// resumption.
+void RecordAcceptsRanges(const std::string& accepts_ranges,
+                         int64 download_len,
+                         bool has_strong_validator);

[Randy Smith (Not in Mondays), 2013/11/18 22:07:02]

This change makes me wary because we're changing what statistic we're recording
without changing how we're displaying it.  That would seem to invite broken
comparisons across releases.  I understand wanting to change this, but I think
that involves retiring the old statistic name and creating a new one.  

[asanka, 2013/11/19 23:53:48]

I deprecated the old UMA and added a new one.

 
 // Record the number of downloads removed by ClearAll.
 void RecordClearAllSize(int size);