[Downloads] Cleanup DownloadResourceHandler

content/browser/download/download_stats.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Holds helpers for gathering UMA stats about downloads.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_STATS_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_STATS_H_
 
 #include <string>
@@ skipping 147 matching lines @@
 
 // Record the bandwidth seen in DownloadResourceHandler
 // |actual_bandwidth| and |potential_bandwidth| are in bytes/second.
 void RecordBandwidth(double actual_bandwidth, double potential_bandwidth);
 
 // Record the time of both the first open and all subsequent opens since the
 // download completed.
 void RecordOpen(const base::Time& end, bool first);
 
 // Record whether or not the server accepts ranges, and the download size. Also
-// counts if a strong ETag is supplied. The combination of range request support
-// and ETag indicates downloads that are candidates for partial resumption.
-void RecordAcceptsRanges(const std::string& accepts_ranges, int64 download_len,
-                         const std::string& etag);
+// counts if a strong validator is supplied. The combination of range request
+// support and ETag indicates downloads that are candidates for partial
+// resumption.
+void RecordAcceptsRanges(const std::string& accepts_ranges,
+                         int64 download_len,
+                         bool has_strong_validator);

[Randy Smith (Not in Mondays), 2013/11/18 22:07:02]

This change makes me wary because we're changing what statistic we're recording
without changing how we're displaying it.  That would seem to invite broken
comparisons across releases.  I understand wanting to change this, but I think
that involves retiring the old statistic name and creating a new one.  

[asanka, 2013/11/19 23:53:48]

I deprecated the old UMA and added a new one.

 
 // Record the number of downloads removed by ClearAll.
 void RecordClearAllSize(int size);
 
 // Record the number of completed unopened downloads when a download is opened.
 void RecordOpensOutstanding(int size);
 
 // Record how long we block the file thread at a time.
 void RecordContiguousWriteTime(base::TimeDelta time_blocked);
 
@@ skipping 25 matching lines @@
   SAVE_PACKAGE_WRITE_TO_FAILED,
 
   SAVE_PACKAGE_LAST_ENTRY
 };
 
 void RecordSavePackageEvent(SavePackageEvent event);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_STATS_H_