chrome/browser/ui/webui/ntp/most_visited_handler.cc - Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.cc

Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates from nasko comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/most_visited_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.cc b/chrome/browser/ui/webui/ntp/most_visited_handler.cc

index ba6e7e0b79a1337e6a7271ea09b51598f1e3d639..a43c6341b0239c0a4000bc3b1490979a661699a4 100644

--- a/chrome/browser/ui/webui/ntp/most_visited_handler.cc

+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.cc

@@ -64,7 +64,7 @@ MostVisitedHandler::~MostVisitedHandler() {

const GURL ntp_url = GURL(chrome::kChromeUINewTabURL);

int action_id = NTP_FOLLOW_ACTION_OTHER;

content::NavigationEntry* entry =

- web_ui()->GetWebContents()->GetController().GetActiveEntry();

+ web_ui()->GetWebContents()->GetController().GetLastCommittedEntry();

if (entry && (entry->GetURL() != ntp_url)) {

action_id =

content::PageTransitionStripQualifier(entry->GetTransitionType());