chrome/browser/ui/views/external_tab_container_win.cc - Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_tab_container_win.cc

Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates from nasko comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/external_tab_container_win.cc

diff --git a/chrome/browser/ui/views/external_tab_container_win.cc b/chrome/browser/ui/views/external_tab_container_win.cc

index 9fa14db90b3165e12324722b8e8b237478b25d7a..bdd05c6866249798900039bffdbce2b5aa7fc845 100644

--- a/chrome/browser/ui/views/external_tab_container_win.cc

+++ b/chrome/browser/ui/views/external_tab_container_win.cc

@@ -1214,7 +1214,7 @@ bool ExternalTabContainerWin::InitNavigationInfo(

content::NavigationType nav_type,

int relative_offset) {

DCHECK(nav_info);

- NavigationEntry* entry = web_contents_->GetController().GetActiveEntry();

+ NavigationEntry* entry = web_contents_->GetController().GetVisibleEntry();

// If this is very early in the game then there may not be an entry.

if (!entry)

return false;