Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 669883002: fix broken xdisplaycheck dependency (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

fix broken xdisplaycheck dependency Followup to: https://codereview.chromium.org/601263002 BUG=416594 Committed: https://crrev.com/37460d48a5c667a88b0d93eb29291d463a426177 Cr-Commit-Position: refs/heads/master@{#300508}

Patch Set 1 #

Patch Set 2 : just check use_x11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Mostyn Bramley-Moore
@Jamie, Charlie: please take a look at this small fixup after CL 601263002.
6 years, 2 months ago (2014-10-21 10:22:54 UTC) #2
Jamie Madill
LGTM.. I believe I had copy/pasted the code from another target, so I appreciate someone ...
6 years, 2 months ago (2014-10-21 15:23:17 UTC) #3
Charlie Reis
Rubber stamp LGTM.
6 years, 2 months ago (2014-10-21 16:18:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669883002/20001
6 years, 2 months ago (2014-10-21 16:21:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 17:14:58 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:16:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37460d48a5c667a88b0d93eb29291d463a426177
Cr-Commit-Position: refs/heads/master@{#300508}

Powered by Google App Engine
This is Rietveld 408576698