Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 601263002: Update content and media unittest isolate targets. (Closed)

Created:
6 years, 2 months ago by Jamie Madill
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update content and media unittest isolate targets. These two tests are planned to be run on the GPU bots. The isolates needed a few fixes to get them running smoothly. BUG=416594 Committed: https://crrev.com/d6f2d5b93c943a57727832c886ac9bd7d64c5b05 Cr-Commit-Position: refs/heads/master@{#297423}

Patch Set 1 #

Patch Set 2 : Add base.isolate to content_unittests.isolate #

Patch Set 3 : Fix Windows ffmpeg dll dep #

Patch Set 4 : Fix Android isolate #

Patch Set 5 : Fix isolate typo #

Patch Set 6 : Fix isolate typo #2 #

Patch Set 7 : Isolate Typo #3 #

Patch Set 8 : Fix merge conflict #

Total comments: 1

Patch Set 9 : Mark as tracked #

Total comments: 1

Patch Set 10 : Added mac and linux ffmpegsumo dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -0 lines 0 comments Download
M media/media_unittests.isolate View 1 2 3 4 5 6 7 8 9 1 chunk +36 lines, -1 line 0 comments Download

Messages

Total messages: 17 (3 generated)
Jamie Madill
PTAL. Ken, I didn't explicitly put in the ICU dep because it seemed to build ...
6 years, 2 months ago (2014-09-26 14:43:37 UTC) #2
csharp
https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.isolate File media/media_unittests.isolate (right): https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.isolate#newcode30 media/media_unittests.isolate:30: '<(PRODUCT_DIR)/ffmpegsumo.dll', is ffmpedsumo.dll required to run the test? If ...
6 years, 2 months ago (2014-09-26 15:01:16 UTC) #3
Jamie Madill
On 2014/09/26 15:01:16, csharp wrote: > https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.isolate > File media/media_unittests.isolate (right): > > https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.isolate#newcode30 > ...
6 years, 2 months ago (2014-09-26 18:01:03 UTC) #4
Ken Russell (switch to Gerrit)
Very nice work. LGTM
6 years, 2 months ago (2014-09-26 20:53:52 UTC) #5
DaleCurtis
lgtm
6 years, 2 months ago (2014-09-26 20:55:19 UTC) #6
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.isolate File media/media_unittests.isolate (right): https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.isolate#newcode26 media/media_unittests.isolate:26: # TODO(jmadill): should be automatic. http://crbug.com/418146 Not sure this ...
6 years, 2 months ago (2014-09-26 21:03:42 UTC) #7
Jamie Madill
On 2014/09/26 21:03:42, Ken Russell wrote: > https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.isolate > File media/media_unittests.isolate (right): > > https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.isolate#newcode26 ...
6 years, 2 months ago (2014-09-26 21:05:16 UTC) #8
csharp1
lgtm
6 years, 2 months ago (2014-09-29 20:06:29 UTC) #10
Jamie Madill
On 2014/09/26 21:03:42, Ken Russell wrote: > https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.isolate > File media/media_unittests.isolate (right): > > https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.isolate#newcode26 ...
6 years, 2 months ago (2014-09-29 20:30:49 UTC) #11
Ken Russell (switch to Gerrit)
On 2014/09/29 20:30:49, Jamie Madill wrote: > On 2014/09/26 21:03:42, Ken Russell wrote: > > ...
6 years, 2 months ago (2014-09-29 21:06:31 UTC) #12
Jamie Madill
Added the extra deps, as you suggested, and CQ'ing.
6 years, 2 months ago (2014-09-30 14:14:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601263002/180001
6 years, 2 months ago (2014-09-30 14:29:36 UTC) #15
commit-bot: I haz the power
Committed patchset #10 (id:180001) as de22ccb74b6e6c86ebac82ca9382f726971a2a55
6 years, 2 months ago (2014-09-30 15:00:30 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 15:01:04 UTC) #17
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/d6f2d5b93c943a57727832c886ac9bd7d64c5b05
Cr-Commit-Position: refs/heads/master@{#297423}

Powered by Google App Engine
This is Rietveld 408576698