Update content and media unittest isolate targets.

Update content and media unittest isolate targets.

These two tests are planned to be run on the GPU bots. The isolates
needed a few fixes to get them running smoothly.

BUG=416594
Committed: https://crrev.com/d6f2d5b93c943a57727832c886ac9bd7d64c5b05
Cr-Commit-Position: refs/heads/master@{#297423}

[Jamie Madill, 2014-09-25 20:37:08]

jmadill@chromium.org changed reviewers:
+ csharp@chromium.org, dalecurtis@chromium.org, kbr@chromium.org

[Jamie Madill, 2014-09-26 14:43:37]

PTAL.

Ken, I didn't explicitly put in the ICU dep because it seemed to build it
already. I could add the dep to these targets.

[csharp, 2014-09-26 15:01:16]

https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.i...
File media/media_unittests.isolate (right):

https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.i...
media/media_unittests.isolate:30: '<(PRODUCT_DIR)/ffmpegsumo.dll',
is ffmpedsumo.dll required to run the test? If so, I'm pretty sure it should be
a tracked dependency

[Jamie Madill, 2014-09-26 18:01:03]

On 2014/09/26 15:01:16, csharp wrote:
>
https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.i...
> File media/media_unittests.isolate (right):
> 
>
https://codereview.chromium.org/601263002/diff/140001/media/media_unittests.i...
> media/media_unittests.isolate:30: '<(PRODUCT_DIR)/ffmpegsumo.dll',
> is ffmpedsumo.dll required to run the test? If so, I'm pretty sure it should
be
> a tracked dependency

Changed to a tracked dependency and opened an issue as you suggested. PTAL.

[Ken Russell (switch to Gerrit), 2014-09-26 20:53:52]

Very nice work. LGTM

[DaleCurtis, 2014-09-26 20:55:19]

lgtm

[Ken Russell (switch to Gerrit), 2014-09-26 21:03:42]

https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
File media/media_unittests.isolate (right):

https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
media/media_unittests.isolate:26: # TODO(jmadill): should be automatic.
http://crbug.com/418146
Not sure this is automatically included yet. Per comment on Issue 418146 I think
it's necessary to copy the Linux and Mac sections for this dependency.

[Jamie Madill, 2014-09-26 21:05:16]

On 2014/09/26 21:03:42, Ken Russell wrote:
>
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
> File media/media_unittests.isolate (right):
> 
>
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
> media/media_unittests.isolate:26: # TODO(jmadill): should be automatic.
> http://crbug.com/418146
> Not sure this is automatically included yet. Per comment on Issue 418146 I
think
> it's necessary to copy the Linux and Mac sections for this dependency.

I haven't tested on Mac, but on Linux it was automatically included. Not sure
what's up with chrome.isolate.

[csharp1, 2014-09-29 20:06:28]

csharp@google.com changed reviewers:
+ csharp@google.com

[csharp1, 2014-09-29 20:06:29]

lgtm

[Jamie Madill, 2014-09-29 20:30:49]

On 2014/09/26 21:03:42, Ken Russell wrote:
>
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
> File media/media_unittests.isolate (right):
> 
>
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
> media/media_unittests.isolate:26: # TODO(jmadill): should be automatic.
> http://crbug.com/418146
> Not sure this is automatically included yet. Per comment on Issue 418146 I
think
> it's necessary to copy the Linux and Mac sections for this dependency.

Ken, was my answer satisfactory or is there something I should do about this?

[Ken Russell (switch to Gerrit), 2014-09-29 21:06:31]

On 2014/09/29 20:30:49, Jamie Madill wrote:
> On 2014/09/26 21:03:42, Ken Russell wrote:
> >
>
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
> > File media/media_unittests.isolate (right):
> > 
> >
>
https://codereview.chromium.org/601263002/diff/160001/media/media_unittests.i...
> > media/media_unittests.isolate:26: # TODO(jmadill): should be automatic.
> > http://crbug.com/418146
> > Not sure this is automatically included yet. Per comment on Issue 418146 I
> think
> > it's necessary to copy the Linux and Mac sections for this dependency.
> 
> Ken, was my answer satisfactory or is there something I should do about this?

I don't understand why the .so would be automatically included on Mac and Linux
unless the component build was being used. It seems to me the safest thing to do
would be to copy the ffmpegsumo portions of chrome.isolate for Mac and Linux in
here. That would avoid the risk of breakage when this is deployed to the
tryservers and the main waterfall. But if the isolate already works everywhere,
LGTM.

[Jamie Madill, 2014-09-30 14:14:32]

Added the extra deps, as you suggested, and CQ'ing.

[Jamie Madill, 2014-09-30 14:28:47]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2014-09-30 14:29:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/601263002/180001

[commit-bot: I haz the power, 2014-09-30 15:00:30]

Committed patchset #10 (id:180001) as de22ccb74b6e6c86ebac82ca9382f726971a2a55

[commit-bot: I haz the power, 2014-09-30 15:01:04]

Patchset 10 (id:??) landed as
https://crrev.com/d6f2d5b93c943a57727832c886ac9bd7d64c5b05
Cr-Commit-Position: refs/heads/master@{#297423}