Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4030)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.h ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index ed4d30ed289683de1e97bcf9d77cd4ca73a44f06..6dc03f6e6f06636736a231f528ae6c2e2b75a3bb 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -119,18 +119,17 @@ class WorkerObserver
private:
friend class base::RefCountedThreadSafe<WorkerObserver>;
- virtual ~WorkerObserver() {}
+ ~WorkerObserver() override {}
// content::WorkerServiceObserver overrides:
- virtual void WorkerCreated(
- const GURL& url,
- const base::string16& name,
- int process_id,
- int route_id) override {
+ void WorkerCreated(const GURL& url,
+ const base::string16& name,
+ int process_id,
+ int route_id) override {
NotifyOnIOThread();
}
- virtual void WorkerDestroyed(int process_id, int route_id) override {
+ void WorkerDestroyed(int process_id, int route_id) override {
NotifyOnIOThread();
}
@@ -167,16 +166,16 @@ class LocalTargetsUIHandler
public content::NotificationObserver {
public:
explicit LocalTargetsUIHandler(const Callback& callback);
- virtual ~LocalTargetsUIHandler();
+ ~LocalTargetsUIHandler() override;
// DevToolsTargetsUIHandler overrides.
- virtual void ForceUpdate() override;
+ void ForceUpdate() override;
private:
// content::NotificationObserver overrides.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
void ScheduleUpdate();
void UpdateTargets();
@@ -278,18 +277,18 @@ class AdbTargetsUIHandler
public DevToolsAndroidBridge::DeviceListListener {
public:
AdbTargetsUIHandler(const Callback& callback, Profile* profile);
- virtual ~AdbTargetsUIHandler();
+ ~AdbTargetsUIHandler() override;
- virtual void Open(const std::string& browser_id,
- const std::string& url,
- const DevToolsTargetsUIHandler::TargetCallback&) override;
+ void Open(const std::string& browser_id,
+ const std::string& url,
+ const DevToolsTargetsUIHandler::TargetCallback&) override;
- virtual scoped_refptr<content::DevToolsAgentHost> GetBrowserAgentHost(
+ scoped_refptr<content::DevToolsAgentHost> GetBrowserAgentHost(
const std::string& browser_id) override;
private:
// DevToolsAndroidBridge::Listener overrides.
- virtual void DeviceListChanged(
+ void DeviceListChanged(
const DevToolsAndroidBridge::RemoteDevices& devices) override;
DevToolsAndroidBridge* GetAndroidBridge();
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.h ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698