chrome/browser/devtools/chrome_devtools_manager_delegate.h - Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.h

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/browser_list_tabcontents_provider.h ('k') | chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/chrome_devtools_manager_delegate.h

diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.h b/chrome/browser/devtools/chrome_devtools_manager_delegate.h

index 8feb73433959a7eaed44450afa83975bef15d84d..693e9b4bf436598e1e0c3b55c457ec93ddf0ab75 100644

--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.h

+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.h

@@ -14,20 +14,19 @@

class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {

public:

ChromeDevToolsManagerDelegate();

- virtual ~ChromeDevToolsManagerDelegate();

+ ~ChromeDevToolsManagerDelegate() override;

// content::DevToolsManagerDelegate implementation.

- virtual void Inspect(content::BrowserContext* browser_context,

- content::DevToolsAgentHost* agent_host) override;

- virtual void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,

- bool attached) override;

- virtual base::DictionaryValue* HandleCommand(

+ void Inspect(content::BrowserContext* browser_context,

+ content::DevToolsAgentHost* agent_host) override;

+ void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,

+ bool attached) override;

+ base::DictionaryValue* HandleCommand(

content::DevToolsAgentHost* agent_host,

base::DictionaryValue* command_dict) override;

- virtual scoped_ptr<content::DevToolsTarget> CreateNewTarget(

- const GURL& url) override;

- virtual void EnumerateTargets(TargetCallback callback) override;

- virtual std::string GetPageThumbnailData(const GURL& url) override;

+ scoped_ptr<content::DevToolsTarget> CreateNewTarget(const GURL& url) override;

+ void EnumerateTargets(TargetCallback callback) override;

+ std::string GetPageThumbnailData(const GURL& url) override;

private:

scoped_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;